You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Erzsebet Szilagyi <er...@gmail.com> on 2016/11/02 10:57:33 UTC
Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not
checked for empty strings before passing to MR
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/
-----------------------------------------------------------
(Updated Nov. 2, 2016, 11:57 a.m.)
Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and Szabolcs Vasas.
Bugs: SQOOP-3013
https://issues.apache.org/jira/browse/SQOOP-3013
Repository: sqoop-trunk
Description
-------
When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize the list of empty strings.
Sqoop should remove empty strings before starting the MR job and raise a warning if an empty string was found.
The proposed changes check for empty strings in "tmpjars" and remove them along with raising a warning.
Diffs (updated)
-----
src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684
src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION
Diff: https://reviews.apache.org/r/52212/diff/
Testing
-------
- Live test with command including: "tmpjars=,,valid,,,validother,,,"
- Unit tests
Thanks,
Erzsebet Szilagyi
Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not
checked for empty strings before passing to MR
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/#review154889
-----------------------------------------------------------
Ship it!
Hi Liz,
It is a nice solution to use a spy to verify if logging happened! I have just a hair splitting comment: I can see that org.apache.accumulo.core.util.StringUtil import is added but it is not actually used in JobBase, we could remove it.
Thanks,
Szabolcs
- Szabolcs Vasas
On Nov. 4, 2016, 8:29 a.m., Erzsebet Szilagyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52212/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2016, 8:29 a.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3013
> https://issues.apache.org/jira/browse/SQOOP-3013
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize the list of empty strings.
> Sqoop should remove empty strings before starting the MR job and raise a warning if an empty string was found.
>
> The proposed changes check for empty strings in "tmpjars" and remove them along with raising a warning.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684
> src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52212/diff/
>
>
> Testing
> -------
>
> - Live test with command including: "tmpjars=,,valid,,,validother,,,"
> - Unit tests
>
>
> Thanks,
>
> Erzsebet Szilagyi
>
>
Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not
checked for empty strings before passing to MR
Posted by Attila Szabo <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/#review155576
-----------------------------------------------------------
Ship it!
Nice job Liz!
Especially from testing POV. Way to go!
- Attila Szabo
On Nov. 4, 2016, 12:33 p.m., Erzsebet Szilagyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52212/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2016, 12:33 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3013
> https://issues.apache.org/jira/browse/SQOOP-3013
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize the list of empty strings.
> Sqoop should remove empty strings before starting the MR job and raise a warning if an empty string was found.
>
> The proposed changes check for empty strings in "tmpjars" and remove them along with raising a warning.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684
> src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52212/diff/
>
>
> Testing
> -------
>
> - Live test with command including: "tmpjars=,,valid,,,validother,,,"
> - Unit tests
>
>
> Thanks,
>
> Erzsebet Szilagyi
>
>
Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not
checked for empty strings before passing to MR
Posted by Erzsebet Szilagyi <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 1:33 p.m.)
Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and Szabolcs Vasas.
Changes
-------
removing unused import
Bugs: SQOOP-3013
https://issues.apache.org/jira/browse/SQOOP-3013
Repository: sqoop-trunk
Description
-------
When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize the list of empty strings.
Sqoop should remove empty strings before starting the MR job and raise a warning if an empty string was found.
The proposed changes check for empty strings in "tmpjars" and remove them along with raising a warning.
Diffs (updated)
-----
src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684
src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION
Diff: https://reviews.apache.org/r/52212/diff/
Testing
-------
- Live test with command including: "tmpjars=,,valid,,,validother,,,"
- Unit tests
Thanks,
Erzsebet Szilagyi
Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not
checked for empty strings before passing to MR
Posted by Erzsebet Szilagyi <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/
-----------------------------------------------------------
(Updated Nov. 4, 2016, 9:29 a.m.)
Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and Szabolcs Vasas.
Changes
-------
(renaming methods)
Bugs: SQOOP-3013
https://issues.apache.org/jira/browse/SQOOP-3013
Repository: sqoop-trunk
Description
-------
When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize the list of empty strings.
Sqoop should remove empty strings before starting the MR job and raise a warning if an empty string was found.
The proposed changes check for empty strings in "tmpjars" and remove them along with raising a warning.
Diffs (updated)
-----
src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684
src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION
Diff: https://reviews.apache.org/r/52212/diff/
Testing
-------
- Live test with command including: "tmpjars=,,valid,,,validother,,,"
- Unit tests
Thanks,
Erzsebet Szilagyi