You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by VipinRathor <gi...@git.apache.org> on 2017/08/22 01:55:35 UTC

[GitHub] zeppelin pull request #2545: ZEPPELIN-2873 - Add documentation on secure coo...

GitHub user VipinRathor opened a pull request:

    https://github.com/apache/zeppelin/pull/2545

    ZEPPELIN-2873 - Add documentation on secure cookie in Shiro

    ### What is this PR for?
    Adding a section in Shiro Authentication about how to enable secure cookie via Shiro. Shiro do support configuring 'HttpOnly' flag in response cookie. A Zeppelin user, who is security conscious, should know how to enable this in Zeppelin's Shiro configuration.
    
    ### What type of PR is it?
    Documentation
    
    ### What is the Jira issue?
    ZEPPELIN-2873
    
    ### How should this be tested?
    Doc changes. CI test should pass.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/VipinRathor/zeppelin ZEPPELIN-2873

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2545
    
----
commit fec8d7edc2fee4d1950f813c4022e75d7c26f802
Author: Vipin Rathor <v....@gmail.com>
Date:   2017-08-22T01:47:32Z

    ZEPPELIN-2873 - Add documentation on Zeppelin Shiro's abliity to configure secure cookie
    
    Added secure cookie option description in Shiro Authentiction doc.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2545: ZEPPELIN-2873 - Add documentation on secure cookie in ...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2545
  
    Looks good to me.
    
    @VipinRathor do you think it's good idea configure httpOnly flag in `conf/shiro.ini.template` file by default?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2545: ZEPPELIN-2873 - Add documentation on secure cookie in ...

Posted by VipinRathor <gi...@git.apache.org>.
Github user VipinRathor commented on the issue:

    https://github.com/apache/zeppelin/pull/2545
  
    Thanks @krishna-pandey & @Leemoonsoo for reviewing this.
    I have updated the doc as suggested by @krishna-pandey .
    @Leemoonsoo I like your suggestion for updating the shiro.ini template. Doing that in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2545: ZEPPELIN-2873 - Add documentation on secure coo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2545


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2545: ZEPPELIN-2873 - Add documentation on secure cookie in ...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2545
  
    LGTM. Merge to master and branch-0.7 if no further discussions.
    
    Thanks @VipinRathor for the contribution!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2545: ZEPPELIN-2873 - Add documentation on secure cookie in ...

Posted by VipinRathor <gi...@git.apache.org>.
Github user VipinRathor commented on the issue:

    https://github.com/apache/zeppelin/pull/2545
  
    @prabhjyotsingh @Leemoonsoo Please help with review. 
    For some context on httpOnly flag, please check
    https://www.owasp.org/index.php/HttpOnly
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---