You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Liyin (Liyin Tang)" <ph...@reviews.facebook.net> on 2011/10/28 01:56:49 UTC

[Differential] [Accepted] D87: [jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation

Liyin has accepted the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation
".

  It looks good to me. Just one minor comments:

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:384 This api looks like very hard to use.
  Maybe we can elaborate what's in the map a little bit:)

REVISION DETAIL
  https://reviews.facebook.net/D87