You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/06/15 03:41:53 UTC

[GitHub] [mynewt-nimble] t3zeng commented on a diff in pull request #1276: Properly accumulate full ACL packet before sending to BLE controller

t3zeng commented on code in PR #1276:
URL: https://github.com/apache/mynewt-nimble/pull/1276#discussion_r897504887


##########
nimble/transport/apollo3/src/apollo3_ble_hci.c:
##########
@@ -40,10 +40,10 @@ typedef enum {
 /* Structure for holding outgoing HCI packets. */
 typedef struct {
     uint32_t len;
-    uint32_t data[MYNEWT_VAL(BLE_TRANSPORT_APOLLO3_MAX_TX_PACKET) / sizeof(uint32_t)];
+    uint8_t data[MYNEWT_VAL(BLE_TRANSPORT_APOLLO3_MAX_TX_PACKET)];

Review Comment:
   Seems reasonable, I'll change it back to ensure alignment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org