You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/01/08 19:14:09 UTC
Review Request 42073: Fix exception thrown in SchedulingBenchmarks
set up.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42073/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
SchedulingBenchmarks were broken because of a missing binding to `TeirConfig` and an invalid parameter to `PreemptorModule`.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 2c09341ce55420bcbb749a85c5198ac111668aa2
src/main/java/org/apache/aurora/scheduler/TierManager.java 2866efdde1b5f88642f79cac5a64d45f19e2fac1
Diff: https://reviews.apache.org/r/42073/diff/
Testing
-------
./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'
Thanks,
Zameer Manji
Re: Review Request 42073: Fix exception thrown in
SchedulingBenchmarks set up.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42073/#review113498
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 8, 2016, 6:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42073/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 6:14 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> SchedulingBenchmarks were broken because of a missing binding to `TeirConfig` and an invalid parameter to `PreemptorModule`.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 2c09341ce55420bcbb749a85c5198ac111668aa2
> src/main/java/org/apache/aurora/scheduler/TierManager.java 2866efdde1b5f88642f79cac5a64d45f19e2fac1
>
> Diff: https://reviews.apache.org/r/42073/diff/
>
>
> Testing
> -------
>
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'
>
>
> Thanks,
>
> Zameer Manji
>
>