You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "skrcode (via GitHub)" <gi...@apache.org> on 2026/08/22 13:52:17 UTC
Re: [PR] refactor: throw exception in registerConsumer + lock-free StoreStatsService [rocketmq]
skrcode commented on PR #10815:
URL: https://github.com/apache/rocketmq/pull/10815#issuecomment-5380754481
JAIPilot Cloud reviewed exact head `5150a9fe21589c6d0faa884b61042e94fc1d8d5e` and found that the change does not compile because `MQClientInstance` uses `FAQUrl` without importing it. I opened an AI-assisted draft against the contributor branch: https://github.com/juincen/rocketmq/pull/1
The draft adds that import, repairs stale `registerConsumer` tests for the new exception contract, and adds four tests for sequential and concurrent max tracking. The cloud sandbox passed the focused behavior suite (84 baseline / 88 candidate tests), affected client/store test compilation, and Checkstyle. The entire RocketMQ suite was not run, so I am not claiming repository-wide verification. The result was independently reviewed for scope before sharing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org