You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/13 08:13:25 UTC
[GitHub] [avro] sekikn opened a new pull request #984: AVRO-2975: Enable PHP linting and fix its errors
sekikn opened a new pull request #984:
URL: https://github.com/apache/avro/pull/984
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2975
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
No additional unit test, since this PR fixes the test itself. I ran `./build.sh clean test` in the Docker container locally and confirmed it succeeded.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #984: AVRO-2975: Enable PHP linting and fix its errors
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #984:
URL: https://github.com/apache/avro/pull/984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] sekikn commented on a change in pull request #984: AVRO-2975: Enable PHP linting and fix its errors
Posted by GitBox <gi...@apache.org>.
sekikn commented on a change in pull request #984:
URL: https://github.com/apache/avro/pull/984#discussion_r523420547
##########
File path: build.sh
##########
@@ -92,7 +92,7 @@ do
(cd lang/csharp; ./build.sh test)
(cd lang/js; ./build.sh lint test)
(cd lang/ruby; ./build.sh lint test)
- (cd lang/php; ./build.sh test)
+ (cd lang/php; ./build.sh lint test)
Review comment:
Thank you for the comment @RyanSkraba! Will update the PR soon :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #984: AVRO-2975: Enable PHP linting and fix its errors
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #984:
URL: https://github.com/apache/avro/pull/984#issuecomment-727838337
Thanks for this improvement. Travis isn't running the CI so I ran a full build on my local machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a change in pull request #984: AVRO-2975: Enable PHP linting and fix its errors
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #984:
URL: https://github.com/apache/avro/pull/984#discussion_r522872483
##########
File path: build.sh
##########
@@ -92,7 +92,7 @@ do
(cd lang/csharp; ./build.sh test)
(cd lang/js; ./build.sh lint test)
(cd lang/ruby; ./build.sh lint test)
- (cd lang/php; ./build.sh test)
+ (cd lang/php; ./build.sh lint test)
Review comment:
Ooops, this breaks on a **clean** build on my system!
```
+ cd lang/php
+ ./build.sh lint test
No syntax errors detected in ./test/IODatumReaderTest.php
No syntax errors detected in ./test/test_helper.php
No syntax errors detected in ./examples/write_read.php
No syntax errors detected in ./test/ProtocolFileTest.php
No syntax errors detected in ./test/InterOpTest.php
No syntax errors detected in ./test/FloatIntEncodingTest.php
No syntax errors detected in ./test/LongEncodingTest.php
No syntax errors detected in ./test/StringIOTest.php
No syntax errors detected in ./test/generate_interop_data.php
No syntax errors detected in ./test/NameTest.php
No syntax errors detected in ./test/DataFileTest.php
No syntax errors detected in ./lib/AvroIO.php
No syntax errors detected in ./test/SchemaTest.php
No syntax errors detected in ./test/DatumIOTest.php
No syntax errors detected in ./lib/Protocol/AvroProtocolParseException.php
No syntax errors detected in ./lib/Protocol/AvroProtocol.php
No syntax errors detected in ./lib/AvroNotImplementedException.php
No syntax errors detected in ./lib/Protocol/AvroProtocolMessage.php
No syntax errors detected in ./lib/AvroUtil.php
No syntax errors detected in ./lib/autoload.php
No syntax errors detected in ./lib/Schema/AvroSchemaParseException.php
No syntax errors detected in ./lib/Schema/AvroMapSchema.php
No syntax errors detected in ./lib/Schema/AvroArraySchema.php
No syntax errors detected in ./lib/Schema/AvroName.php
No syntax errors detected in ./lib/Schema/AvroFixedSchema.php
No syntax errors detected in ./lib/Schema/AvroSchema.php
No syntax errors detected in ./lib/Schema/AvroRecordSchema.php
No syntax errors detected in ./lib/Schema/AvroUnionSchema.php
No syntax errors detected in ./lib/Schema/AvroNamedSchemata.php
No syntax errors detected in ./lib/Schema/AvroField.php
No syntax errors detected in ./lib/Schema/AvroEnumSchema.php
No syntax errors detected in ./lib/Schema/AvroPrimitiveSchema.php
No syntax errors detected in ./lib/Schema/AvroNamedSchema.php
No syntax errors detected in ./lib/DataFile/AvroDataIOException.php
No syntax errors detected in ./lib/DataFile/AvroDataIOWriter.php
No syntax errors detected in ./lib/DataFile/AvroDataIO.php
No syntax errors detected in ./lib/DataFile/AvroDataIOReader.php
No syntax errors detected in ./lib/IO/AvroStringIO.php
No syntax errors detected in ./lib/IO/AvroFile.php
No syntax errors detected in ./lib/IO/AvroIOException.php
No syntax errors detected in ./lib/Avro.php
No syntax errors detected in ./lib/Datum/AvroIOSchemaMatchException.php
No syntax errors detected in ./lib/AvroGMP.php
No syntax errors detected in ./lib/Datum/AvroIOBinaryEncoder.php
No syntax errors detected in ./lib/Datum/AvroIODatumWriter.php
No syntax errors detected in ./lib/Datum/AvroIOBinaryDecoder.php
No syntax errors detected in ./lib/AvroDebug.php
No syntax errors detected in ./lib/Datum/AvroIOTypeException.php
No syntax errors detected in ./lib/AvroException.php
No syntax errors detected in ./lib/Datum/AvroIODatumReader.php
./build.sh: line 61: vendor/bin/phpcs: No such file or directory
```
phpcs is installed by composer, we can either run `test` before `lint` or call `composer install ...` in the [lint target](https://github.com/sekikn/avro/blob/AVRO-2975/lang/php/build.sh#L59-L67) as well (it looks like calling it twice is fast).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org