You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <wa...@gmail.com> on 2014/11/26 21:20:57 UTC
Review Request 28479: Fix KAFKA-1800
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28479/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1800
https://issues.apache.org/jira/browse/KAFKA-1800
Repository: kafka
Description
-------
1. Add the logic for recoding per-topic record error rate in KafkaProducer handling thrown KafkaExceptions; 2. Move the metrics registration from send requests, since for some corner cases the request may not be sent and hence the per-topic metrics would never be registered
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 32f444ebbd27892275af7a0947b86a6b8317a374
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e
Diff: https://reviews.apache.org/r/28479/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 28479: Fix KAFKA-1800
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28479/#review63145
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/28479/#comment105340>
It would be useful to clarify the comment on why this needed to be moved further up as you explained offline - i.e., since buffer exhaustion (for example) can happen before the sender gets a chance to register the metrics.
Also, we should probably discuss on the jira the additional caveat of failed metadata fetches. i.e., since that happens in the network-client the true record error rate would be higher than what's counted by sendermetrics.
The options that we have are:
* Expose Sender's maybeRegisterTopicMetrics and use that in NetworkClient maybeUpdateMetadata if there are no known partitions for a topic
* Keep it as you have it for now and just accept the above discrepancy - (or we could address that in a separate jira as it is orthogonal).
- Joel Koshy
On Nov. 26, 2014, 8:20 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28479/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 8:20 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1800
> https://issues.apache.org/jira/browse/KAFKA-1800
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Add the logic for recoding per-topic record error rate in KafkaProducer handling thrown KafkaExceptions; 2. Move the metrics registration from send requests, since for some corner cases the request may not be sent and hence the per-topic metrics would never be registered
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 32f444ebbd27892275af7a0947b86a6b8317a374
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e
>
> Diff: https://reviews.apache.org/r/28479/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>