You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "jiang1997 (via GitHub)" <gi...@apache.org> on 2026/10/14 09:22:32 UTC
[PR] fix(desktop): keep conversations centered with classic scrollbars [maka]
jiang1997 opened a new pull request, #6102:
URL: https://github.com/apache/maka/pull/6102
## Summary
Classic scrollbars consume space on the right of the Desktop chat layout, shifting the centered transcript and composer to the left.
Add `scrollbar-gutter: stable both-edges` to keep both centered and their available width stable when the scrollbar appears or disappears. Overlay scrollbars reserve no additional space.
Enable native scrollbars in the Storybook smoke runner and extend the existing EmptyHome scenario to check centering as content grows and shrinks.
## Verification
- Contributor manually verified the fix on Windows and Linux.
- The regression test passes with the fix and fails without it: `expected 5.5 to be less than or equal to 1`.
- Full Storybook smoke with native scrollbars enabled passed on macOS: 459 stories, 499 renders.
- Storybook smoke runner tests passed (16/16).
- Storybook typecheck and build, lint, format check, and `git diff --check` passed.
Linux CI validation of the updated smoke configuration is pending.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex — implementation, automated verification, and PR preparation. The contributor performed manual verification on Windows and Linux.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep conversations centered with classic scrollbars [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6102:
URL: https://github.com/apache/maka/pull/6102#discussion_r4271369316
##########
apps/desktop/src/renderer/styles/chat-header.css:
##########
@@ -169,6 +169,10 @@
.maka-chat-layout {
overscroll-behavior: contain;
+ /* Classic Windows/Linux scrollbars consume inline space. Reserve matching
+ gutters so the transcript and composer stay centered as content grows.
+ Platforms with overlay scrollbars do not reserve either gutter. */
+ scrollbar-gutter: stable both-edges;
Review Comment:
[P3] The default-width layout now hides the usage shortcut earlier. With the right workbar open in the default 1240 px window, these gutters reduce the composer from 420 px to 400 px, exactly triggering its existing hide-at-400px rule. The shortcut is still hidden, although Trace in the Workbar tool list correctly opens the same inspector. This is a visible convenience trade-off rather than a remaining P2: consider keeping the shortcut available at the default width, or explicitly accept its earlier relocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep conversations centered with classic scrollbars [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6102:
URL: https://github.com/apache/maka/pull/6102#discussion_r4270126018
##########
apps/desktop/src/renderer/styles/chat-header.css:
##########
@@ -169,6 +169,10 @@
.maka-chat-layout {
overscroll-behavior: contain;
+ /* Classic Windows/Linux scrollbars consume inline space. Reserve matching
+ gutters so the transcript and composer stay centered as content grows.
+ Platforms with overlay scrollbars do not reserve either gutter. */
+ scrollbar-gutter: stable both-edges;
Review Comment:
[P2] Preserve the existing consumers' width and floating-dock contracts
This global rule also affects the right-workbar conversation and floating WorkHub, not just the centered ordinary transcript. In the actual Electron tests, the right-workbar composer shrinks from 420 px to 400 px, which hides the usage action through its existing container query; WorkHub's expansion gains a 10–22 px left inset instead of its 0–12 px dock gutter. Both exact-head CI failures reproduce locally. Reverting only this declaration makes both unchanged tests pass, including three successive WorkHub fold/unfold motions. Keep the ordinary centering benefit without adding another inset to the floating surface, and preserve or adjust the usage-opening path for the now-narrower composer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep conversations centered with classic scrollbars [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6102:
URL: https://github.com/apache/maka/pull/6102#issuecomment-6208105555
Thanks @jiang1997 for the contribution, and for working through the review feedback. Merging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep conversations centered with classic scrollbars [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6102:
URL: https://github.com/apache/maka/pull/6102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org