[GitHub] [incubator-superset] rusackas commented on a change in pull request #10999: refactor: Remove usages of reactable from TableLoader

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10999:
URL: https://github.com/apache/incubator-superset/pull/10999#discussion_r497989946



##########
File path: superset-frontend/src/components/ListView/ListView.tsx
##########
@@ -48,8 +48,24 @@ const ListViewStyles = styled.div`
     padding-bottom: 48px;
 
     .body {
-      overflow: scroll;
+      overflow: auto;
       max-height: 64vh;
+
+      &::-webkit-scrollbar {
+        -webkit-appearance: none;
+        &:vertical {
+          width: 7px;
+        }
+        &:horizontal {
+          height: 7px;
+        }
+      }
+
+      &::-webkit-scrollbar-thumb {
+        border-radius: 4px;
+        background-color: rgba(0, 0, 0, 0.5);
+        -webkit-box-shadow: 0 0 1px rgba(255, 255, 255, 0.5);

Review comment:
       Aha! It's in Emotion now! I made some comments on https://github.com/apache/incubator-superset/pull/10982 about these color/pixel values, and how they might be updated to leverage the Theme. If those values are used here, it seems that other PR might not need all the LESS code at all?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org