You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jamesfricker (via GitHub)" <gi...@apache.org> on 2023/04/20 10:59:30 UTC
[GitHub] [beam] jamesfricker opened a new pull request, #26368: Update go.mod
jamesfricker opened a new pull request, #26368:
URL: https://github.com/apache/beam/pull/26368
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26368: Bump Go Version to 1.20.3
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26368:
URL: https://github.com/apache/beam/pull/26368#issuecomment-1517845696
@lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck closed pull request #26368: Bump Go Version to 1.20.3
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck closed pull request #26368: Bump Go Version to 1.20.3
URL: https://github.com/apache/beam/pull/26368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26368: Bump Go Version to 1.20.3
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26368:
URL: https://github.com/apache/beam/pull/26368#issuecomment-1518110203
@jamesfricker this doesn't do what you seem to think it does.
The `go` directive in a go.mod specifies the minimum version of Go with which the code in the module can be built with. So it says that The Go beam SDK doesn't rely on language features or features of the standard library that were added after 1.19.
So unless there's a paired change to make use of features introduced in the 1.20 release, there's no real value in changing this.
It also doesn't prevent users from using newer versions of Go (including the patched security releases).
Further, the `go` directive only indicates Major.Minor and doesn't specify Patch. To-wit: As specified, this cases a build failure, caught by our build system (and would have been caught if it had been built locally too)
```
go: errors parsing go.mod:
/home/runner/work/beam/beam/sdks/go.mod:23: invalid go version '1.20.3': must match format 1.23
Error: Process completed with exit code 1.
```
The Go Module reference is quite readable, and explains the `go` directive in detail here:
https://go.dev/ref/mod#go-mod-file-go
----
That said, to update the Beam's Infra to use the latest patch, that kind of PR looks like this https://github.com/apache/beam/pull/26054 though for a patch update, only the BeamModulePlugin.groovy and sdks/go/run_with_go_version.sh files would need changes to ensure the latest patch is used. This only affects releases, when they build the boot loader scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26368: Bump Go Version to 1.20.3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26368:
URL: https://github.com/apache/beam/pull/26368#issuecomment-1516175337
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org