You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/29 02:45:41 UTC
[GitHub] [dolphinscheduler] zwZjut opened a new issue #7035: [Feature][dolphinscheduler-api] project access control
zwZjut opened a new issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
example : user a with no permission of project B can use openapi to queryLog in project B
### Use case
example : user a with no permission of project B can use openapi to queryLog in project B
### Related issues
https://github.com/apache/dolphinscheduler/issues/6875
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut commented on issue #7035: [Feature][dolphinscheduler-api] access control of resources in project like taskDefinition,ProcessDefinition,etc
Posted by GitBox <gi...@apache.org>.
zwZjut commented on issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035#issuecomment-981406797
I think we need set the projectcode as input parameter when querying metadata, or compare it with the projectcode after the result is returned. The change is small, but there are many classes.
if you have a better idea, please leave a message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut closed issue #7035: [Feature][dolphinscheduler-api] access control of resources in project like taskDefinition,ProcessDefinition,etc
Posted by GitBox <gi...@apache.org>.
zwZjut closed issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut commented on issue #7035: [Feature][dolphinscheduler-api] project access control
Posted by GitBox <gi...@apache.org>.
zwZjut commented on issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035#issuecomment-981299997
num | Interface | Interface method | reason
-- | -- | -- | -- | --
1 | ExecutorService | execProcessInstance | processDefinitionMapper.queryByCode used in this method
2 | ExecutorService | execute | findProcessInstanceDetailById used in this method
3 | ExecutorService | startCheckByProcessDefinedCode | need add projectCode as input parameter
4 | LoggerService | queryLog | need add projectCode as input parameter
5 | LoggerService | downloadTaskLog | need add projectCode as input parameter
6 | ProcessDefinitionService | updateProcessDefinition | processDefinitionMapper.queryByCode used in this method
7 | ProcessDefinitionService | queryProcessDefinitionVersions | processDefinitionLogMapper.queryProcessDefinitionVersionsPaging used in this method
8 | ProcessDefinitionService | switchProcessDefinitionVersion | processDefinitionMapper.queryByCode and processDefinitionLogMapper.queryByDefinitionCodeAndVersion used in this method
9 | ProcessDefinitionService | deleteProcessDefinitionVersion | processDefinitionMapper.queryByCode , processDefinitionLogMapper.deleteByProcessDefinitionCodeAndVersion and processTaskRelationLogMapper.deleteByCode used in this method
10 | ProcessDefinitionService | releaseProcessDefinition | processDefinitionMapper.queryByCode used in this method
11 | ProcessDefinitionService | queryProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
12 | ProcessDefinitionService | viewTree | processDefinitionMapper.queryByCode used in this method
13 | ProcessDefinitionService | getTaskNodeListByDefinitionCode | processDefinitionMapper.queryByCode used in this method
14 | ProcessDefinitionService | getNodeListMapByDefinitionCodes | processDefinitionMapper.queryByCodes used in this method
15 | ProcessDefinitionService | deleteProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
16 | ProcessDefinitionService | batchDeleteProcessDefinitionByCodes | deleteProcessDefinitionByCode used in this method
17 | ProcessDefinitionService | batchExportProcessDefinitionByCodes | processDefinitionMapper.queryByCodes used in this method
18 | ProcessInstanceService | queryTaskListByProcessId | processService.findProcessInstanceDetailById used in this method
19 | ProcessInstanceService | updateProcessInstance | processService.findProcessInstanceDetailById used in this method
20 | ProcessInstanceService | queryProcessInstanceById | processService.findProcessInstanceDetailById used in this method
21 | ProcessInstanceService | queryTopNLongestRunningProcessInstance | processInstanceMapper.queryTopNProcessInstance used in this method
22 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
23 | ProcessInstanceService | querySubProcessInstanceByTaskId | processService.findTaskInstanceById used in this method
24 | ProcessInstanceService | queryParentInstanceBySubId | processService.findProcessInstanceDetailById used in this method
25 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
26 | ProcessInstanceService | viewVariables | processInstanceMapper.queryDetailById used in this method
27 | ProcessInstanceService | viewGantt | processInstanceMapper.queryDetailById used in this method
28 | TaskDefinitionServive | createTaskDefinition | taskDefinitionMapper.queryByCode used in this method
29 | TaskDefinitionService | queryTaskDefinitionVersions | taskDefinitionLogMapper.queryTaskDefinitionVersionsPaging used in this method
30 | TaskDefinitionService | switchVersion | taskDefinitionMapper.queryByCode used in this method
31 | TaskDefinitionService | deleteTaskDefinitionVersion | taskDefinitionMapper.queryByCode used in this method
32 | TaskDefinitionService | deleteTaskDefinitionByCode | taskDefinitionMapper.queryByCode used in this method
33 | TaskDefinitionService | queryTaskDefinitionDetail | taskDefinitionMapper.queryByCode used in this method
34 | TaskDefinitionService | releaseTaskDefinition | taskDefinitionMapper.queryByCode used in this method
35 | TaskInstanceService | forceTaskSuccess | taskInstanceMapper.selectById(taskInstanceId) used in this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut edited a comment on issue #7035: [Feature][dolphinscheduler-api] access control of resources in project like taskDefinition,ProcessDefinition,etc
Posted by GitBox <gi...@apache.org>.
zwZjut edited a comment on issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035#issuecomment-981299997
num | Interface | Interface method | reason
-- | -- | -- | --
1 | ExecutorService | execProcessInstance | processDefinitionMapper.queryByCode used in this method
2 | ExecutorService | execute | findProcessInstanceDetailById used in this method
3 | ExecutorService | startCheckByProcessDefinedCode | need add projectCode as input parameter
4 | LoggerService | queryLog | need add projectCode as input parameter
5 | LoggerService | downloadTaskLog | need add projectCode as input parameter
6 | ProcessDefinitionService | updateProcessDefinition | processDefinitionMapper.queryByCode used in this method
7 | ProcessDefinitionService | queryProcessDefinitionVersions | processDefinitionLogMapper.queryProcessDefinitionVersionsPaging used in this method
8 | ProcessDefinitionService | switchProcessDefinitionVersion | processDefinitionMapper.queryByCode and processDefinitionLogMapper.queryByDefinitionCodeAndVersion used in this method
9 | ProcessDefinitionService | deleteProcessDefinitionVersion | processDefinitionMapper.queryByCode , processDefinitionLogMapper.deleteByProcessDefinitionCodeAndVersion and processTaskRelationLogMapper.deleteByCode used in this method
10 | ProcessDefinitionService | releaseProcessDefinition | processDefinitionMapper.queryByCode used in this method
11 | ProcessDefinitionService | queryProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
12 | ProcessDefinitionService | viewTree | processDefinitionMapper.queryByCode used in this method
13 | ProcessDefinitionService | getTaskNodeListByDefinitionCode | processDefinitionMapper.queryByCode used in this method
14 | ProcessDefinitionService | getNodeListMapByDefinitionCodes | processDefinitionMapper.queryByCodes used in this method
15 | ProcessDefinitionService | deleteProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
16 | ProcessDefinitionService | batchDeleteProcessDefinitionByCodes | deleteProcessDefinitionByCode used in this method
17 | ProcessDefinitionService | batchExportProcessDefinitionByCodes | processDefinitionMapper.queryByCodes used in this method
18 | ProcessInstanceService | queryTaskListByProcessId | processService.findProcessInstanceDetailById used in this method
19 | ProcessInstanceService | updateProcessInstance | processService.findProcessInstanceDetailById used in this method
20 | ProcessInstanceService | queryProcessInstanceById | processService.findProcessInstanceDetailById used in this method
21 | ProcessInstanceService | queryTopNLongestRunningProcessInstance | processInstanceMapper.queryTopNProcessInstance used in this method
22 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
23 | ProcessInstanceService | querySubProcessInstanceByTaskId | processService.findTaskInstanceById used in this method
24 | ProcessInstanceService | queryParentInstanceBySubId | processService.findProcessInstanceDetailById used in this method
25 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
26 | ProcessInstanceService | viewVariables | processInstanceMapper.queryDetailById used in this method
27 | ProcessInstanceService | viewGantt | processInstanceMapper.queryDetailById used in this method
28 | TaskDefinitionServive | createTaskDefinition | taskDefinitionMapper.queryByCode used in this method
29 | TaskDefinitionService | queryTaskDefinitionVersions | taskDefinitionLogMapper.queryTaskDefinitionVersionsPaging used in this method
30 | TaskDefinitionService | switchVersion | taskDefinitionMapper.queryByCode used in this method
31 | TaskDefinitionService | deleteTaskDefinitionVersion | taskDefinitionMapper.queryByCode used in this method
32 | TaskDefinitionService | deleteTaskDefinitionByCode | taskDefinitionMapper.queryByCode used in this method
33 | TaskDefinitionService | queryTaskDefinitionDetail | taskDefinitionMapper.queryByCode used in this method
34 | TaskDefinitionService | releaseTaskDefinition | taskDefinitionMapper.queryByCode used in this method
35 | TaskInstanceService | forceTaskSuccess | taskInstanceMapper.selectById(taskInstanceId) used in this method
36 | SchedulerService | createSchedule | processDefinitionMapper.queryByCode used in this method
37 | SchedulerService | updateSchedule | processDefinitionMapper.queryByCode used in this method
38 | SchedulerService | setScheduleState | processDefinitionMapper.queryByCode used in this method
39 | SchedulerService | querySchedule | processDefinitionMapper.queryByCode used in this method
40 | SchedulerService | updateScheduleByProcessDefinitionCode | processDefinitionMapper.queryByCode used in this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #7035: [Feature][dolphinscheduler-api] project access control
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035#issuecomment-981241824
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut edited a comment on issue #7035: [Feature][dolphinscheduler-api] project access control
Posted by GitBox <gi...@apache.org>.
zwZjut edited a comment on issue #7035:
URL: https://github.com/apache/dolphinscheduler/issues/7035#issuecomment-981299997
num | Interface | Interface method | reason
-- | -- | -- | --
1 | ExecutorService | execProcessInstance | processDefinitionMapper.queryByCode used in this method
2 | ExecutorService | execute | findProcessInstanceDetailById used in this method
3 | ExecutorService | startCheckByProcessDefinedCode | need add projectCode as input parameter
4 | LoggerService | queryLog | need add projectCode as input parameter
5 | LoggerService | downloadTaskLog | need add projectCode as input parameter
6 | ProcessDefinitionService | updateProcessDefinition | processDefinitionMapper.queryByCode used in this method
7 | ProcessDefinitionService | queryProcessDefinitionVersions | processDefinitionLogMapper.queryProcessDefinitionVersionsPaging used in this method
8 | ProcessDefinitionService | switchProcessDefinitionVersion | processDefinitionMapper.queryByCode and processDefinitionLogMapper.queryByDefinitionCodeAndVersion used in this method
9 | ProcessDefinitionService | deleteProcessDefinitionVersion | processDefinitionMapper.queryByCode , processDefinitionLogMapper.deleteByProcessDefinitionCodeAndVersion and processTaskRelationLogMapper.deleteByCode used in this method
10 | ProcessDefinitionService | releaseProcessDefinition | processDefinitionMapper.queryByCode used in this method
11 | ProcessDefinitionService | queryProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
12 | ProcessDefinitionService | viewTree | processDefinitionMapper.queryByCode used in this method
13 | ProcessDefinitionService | getTaskNodeListByDefinitionCode | processDefinitionMapper.queryByCode used in this method
14 | ProcessDefinitionService | getNodeListMapByDefinitionCodes | processDefinitionMapper.queryByCodes used in this method
15 | ProcessDefinitionService | deleteProcessDefinitionByCode | processDefinitionMapper.queryByCode used in this method
16 | ProcessDefinitionService | batchDeleteProcessDefinitionByCodes | deleteProcessDefinitionByCode used in this method
17 | ProcessDefinitionService | batchExportProcessDefinitionByCodes | processDefinitionMapper.queryByCodes used in this method
18 | ProcessInstanceService | queryTaskListByProcessId | processService.findProcessInstanceDetailById used in this method
19 | ProcessInstanceService | updateProcessInstance | processService.findProcessInstanceDetailById used in this method
20 | ProcessInstanceService | queryProcessInstanceById | processService.findProcessInstanceDetailById used in this method
21 | ProcessInstanceService | queryTopNLongestRunningProcessInstance | processInstanceMapper.queryTopNProcessInstance used in this method
22 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
23 | ProcessInstanceService | querySubProcessInstanceByTaskId | processService.findTaskInstanceById used in this method
24 | ProcessInstanceService | queryParentInstanceBySubId | processService.findProcessInstanceDetailById used in this method
25 | ProcessInstanceService | deleteProcessInstanceById | processService.findProcessInstanceDetailById used in this method
26 | ProcessInstanceService | viewVariables | processInstanceMapper.queryDetailById used in this method
27 | ProcessInstanceService | viewGantt | processInstanceMapper.queryDetailById used in this method
28 | TaskDefinitionServive | createTaskDefinition | taskDefinitionMapper.queryByCode used in this method
29 | TaskDefinitionService | queryTaskDefinitionVersions | taskDefinitionLogMapper.queryTaskDefinitionVersionsPaging used in this method
30 | TaskDefinitionService | switchVersion | taskDefinitionMapper.queryByCode used in this method
31 | TaskDefinitionService | deleteTaskDefinitionVersion | taskDefinitionMapper.queryByCode used in this method
32 | TaskDefinitionService | deleteTaskDefinitionByCode | taskDefinitionMapper.queryByCode used in this method
33 | TaskDefinitionService | queryTaskDefinitionDetail | taskDefinitionMapper.queryByCode used in this method
34 | TaskDefinitionService | releaseTaskDefinition | taskDefinitionMapper.queryByCode used in this method
35 | TaskInstanceService | forceTaskSuccess | taskInstanceMapper.selectById(taskInstanceId) used in this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org