You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Kirk Lund (JIRA)" <ji...@apache.org> on 2016/09/27 21:08:20 UTC

[jira] [Resolved] (GEODE-1939) SocketCreatorFactoryJUnitTest should be categorized as IntegratedTest

     [ https://issues.apache.org/jira/browse/GEODE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kirk Lund resolved GEODE-1939.
------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0-incubating

I also ended up removing some complicated manipulation of logging appenders with simple usage of SystemOutRule.

commit ddf4f3dbc6cbd1ca68ba812128c25163aa5c23ac
Author: Kirk Lund <kl...@apache.org>
Date:   Tue Sep 27 13:50:21 2016 -0700

    GEODE-1939: change test category to IntegrationTest
    
    * remove class hierarchy because it repeats running of tests
    * reformat, privatize vars and methods
    * remove catching of unexpected exceptions
    * remove system out statements
    * move all setup to setup method
    * fix minor concurrency bug in JSSESocketJUnitTest


> SocketCreatorFactoryJUnitTest should be categorized as IntegratedTest
> ---------------------------------------------------------------------
>
>                 Key: GEODE-1939
>                 URL: https://issues.apache.org/jira/browse/GEODE-1939
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>             Fix For: 1.0.0-incubating
>
>
> SocketCreatorFactoryJUnitTest also extends JSSESocketJUnitTest, so it results in rerunning all of the tests in JSSESocketJUnitTest, but without any configuration changes. This is just redundant in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)