You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 18:25:43 UTC

[GitHub] [airflow] o-nikolas commented on a diff in pull request #23402: Introduce sla_miss metric

o-nikolas commented on code in PR #23402:
URL: https://github.com/apache/airflow/pull/23402#discussion_r865142884


##########
tests/dag_processing/test_processor.py:
##########
@@ -231,6 +233,7 @@ def test_dag_file_processor_sla_miss_doesnot_raise_integrity_error(self, dag_mak
             .count()
         )
         assert sla_miss_count == 1
+        mock_stats_incr.assert_called_with('sla_missed')

Review Comment:
   Super small nit: There are other tests that already mock the stats object (for testing other SLA related metrics) that you could add this line to, instead of adding a net-new mock object to this test. But it's not a big deal, still approving. Thanks for the commit :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org