You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/07 19:54:08 UTC

[GitHub] [trafficcontrol] Ayushsunny commented on pull request #5823: Fixed unreachable code on logout_test.go and plugin_verifier.go

Ayushsunny commented on pull request #5823:
URL: https://github.com/apache/trafficcontrol/pull/5823#issuecomment-834734463


   > Everything you've done so far is correct, but your fix has uncovered a bug in `login.TestLogout()`.
   > 
   > These 2 strings (`"test"` and `"secret"`) should instead be the same string:
   > 
   > https://github.com/apache/trafficcontrol/blob/55dbb7eacd399d3ccef9d4eb34bfaeb0c5e2e7ad/traffic_ops/traffic_ops_golang/login/logout_test.go#L103
   > 
   > https://github.com/apache/trafficcontrol/blob/55dbb7eacd399d3ccef9d4eb34bfaeb0c5e2e7ad/traffic_ops/traffic_ops_golang/login/logout_test.go#L135
   > 
   > Once they are the same string, the test should pass.
   
   Thank you @zrhoffman.
   I have amend the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org