You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Raluca Miclea <rm...@cloudbasesolutions.com> on 2017/10/25 19:43:06 UTC
Review Request 63304: Removed Flag Tests TODO comments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63304/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Bugs: MESOS-3437
https://issues.apache.org/jira/browse/MESOS-3437
Repository: mesos
Description
-------
Removed Flag Tests TODO comments.
Diffs
-----
3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006
Diff: https://reviews.apache.org/r/63304/diff/1/
Testing
-------
Thanks,
Raluca Miclea
Re: Review Request 63304: Removed Flag Tests TODO comments.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63304/#review189248
-----------------------------------------------------------
This review request should squashed into 63239 (as in, amend the commit used to post 63239, and then re-run the post-reviews script, it will ask to update the existing review, then discard this review).
- Andrew Schwartzmeyer
On Oct. 25, 2017, 1:35 p.m., Raluca Miclea wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63304/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 1:35 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-3437
> https://issues.apache.org/jira/browse/MESOS-3437
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed Flag Tests TODO comments.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006
>
>
> Diff: https://reviews.apache.org/r/63304/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raluca Miclea
>
>
Re: Review Request 63304: Removed Flag Tests TODO comments.
Posted by Raluca Miclea <rm...@cloudbasesolutions.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63304/
-----------------------------------------------------------
(Updated Oct. 25, 2017, 8:35 p.m.)
Review request for mesos and Andrew Schwartzmeyer.
Bugs: MESOS-3437
https://issues.apache.org/jira/browse/MESOS-3437
Repository: mesos
Description
-------
Removed Flag Tests TODO comments.
Diffs (updated)
-----
3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006
Diff: https://reviews.apache.org/r/63304/diff/2/
Changes: https://reviews.apache.org/r/63304/diff/1-2/
Testing
-------
Thanks,
Raluca Miclea
Re: Review Request 63304: Removed Flag Tests TODO comments.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63304/#review189239
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 63304`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63304
Relevant logs:
- [apply-review-63304-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63304/logs/apply-review-63304-stdout.log):
```
error: patch failed: 3rdparty/stout/tests/flags_tests.cpp:226
error: 3rdparty/stout/tests/flags_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 25, 2017, 12:43 p.m., Raluca Miclea wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63304/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 12:43 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-3437
> https://issues.apache.org/jira/browse/MESOS-3437
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed Flag Tests TODO comments.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006
>
>
> Diff: https://reviews.apache.org/r/63304/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raluca Miclea
>
>