You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/14 04:06:20 UTC

[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: Rename MasterSlave module to ReadWriteSplit

flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487640251



##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
     <modules>
         <module>shardingsphere-sharding</module>
         <module>shardingsphere-replica</module>
-        <module>shardingsphere-master-slave</module>
+        <module>shardingsphere-primary-replica</module>

Review comment:
       > Hi, @flycoolman
   > You should resolve the conficts first.
   @kimmking Thanks for the suggestion. 
   That will be my next action once the final decision about the module name is made.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org