[GitHub] sijie closed pull request #1493: [table service] Improve logging message on initializing table range stores.

[GitBox <gi...@apache.org>]

sijie closed pull request #1493: [table service] Improve logging message on initializing table range stores.
URL: https://github.com/apache/bookkeeper/pull/1493
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java b/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
index 28f9955ba..6f01d4b59 100644
--- a/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
+++ b/stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/store/MVCCStoreFactoryImpl.java
@@ -136,8 +136,8 @@ private synchronized void addStore(long scId, long streamId, long rangeId,
         if (null != oldStore) {
             store.closeAsync();
         } else {
-            log.info("Add store (scId = {}, streamId = {}, rangeId = {})",
-                scId, streamId, rangeId);
+            log.info("Add store (scId = {}, streamId = {}, rangeId = {}) at storage container ({})",
+                scId, streamId, rangeId, scId);
             scStores.put(rid, store);
         }
     }
@@ -169,6 +169,9 @@ private synchronized void addStore(long scId, long streamId, long rangeId,
             }
         }
 
+        log.info("Initializing stream({})/range({}) at storage container ({})",
+            streamId, rangeId, scId);
+
         MVCCAsyncStore<byte[], byte[]> store = storeSupplier.get();
 
         File targetDir = chooseLocalStoreDir(streamId);
@@ -205,6 +208,8 @@ private synchronized void addStore(long scId, long streamId, long rangeId,
             .build();
 
         return store.init(spec).thenApply(ignored -> {
+            log.info("Successfully initialize stream({})/range({}) at storage container ({})",
+                streamId, rangeId, scId);
             addStore(scId, streamId, rangeId, store);
             return store;
         });


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services