You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pwendell <gi...@git.apache.org> on 2014/05/07 10:42:39 UTC

[GitHub] spark pull request: [WIP]SPARK-1712: TaskDescription instance is t...

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/677#discussion_r12366119
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -414,6 +415,14 @@ private[spark] class TaskSetManager(
               // we assume the task can be serialized without exceptions.
               val serializedTask = Task.serializeWithDependencies(
                 task, sched.sc.addedFiles, sched.sc.addedJars, ser)
    +          if (serializedTask.limit >= akkaFrameSize - 1024) {
    --- End diff --
    
    ah I see - it's to leave room for the other contents of the message. In the second case here, do you know what is taking all the extra room? 2704141 - 2690585 = ~13KB which is very large for a few string/int fields!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---