You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "reiern70 (via GitHub)" <gi...@apache.org> on 2023/08/17 17:01:25 UTC
[GitHub] [wicket] reiern70 commented on a diff in pull request #599: [WICKET-7067] WebSocketResponse does not allow setting a header thus,…
reiern70 commented on code in PR #599:
URL: https://github.com/apache/wicket/pull/599#discussion_r1297499851
##########
wicket-core/src/main/java/org/apache/wicket/DefaultExceptionMapper.java:
##########
@@ -56,8 +56,15 @@ public IRequestHandler map(Exception e)
Response response = RequestCycle.get().getResponse();
if (response instanceof WebResponse)
{
- // we don't want to cache an exceptional reply in the browser
- ((WebResponse)response).disableCaching();
+ try
Review Comment:
@martin-g I'm not sure thsi is the best way to fix this. Other way would be have silent implementations in
But that sound not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org