You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Joel Swiatek (Jira)" <ji...@apache.org> on 2021/11/16 00:27:00 UTC

[jira] [Updated] (HBASE-26458) Value of hbase.master.snapshot.ttl is not used

     [ https://issues.apache.org/jira/browse/HBASE-26458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Swiatek updated HBASE-26458:
---------------------------------
    Attachment: 0001-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defaulting.patch
        Status: Patch Available  (was: Open)

Initial patch for master branch

> Value of hbase.master.snapshot.ttl is not used
> ----------------------------------------------
>
>                 Key: HBASE-26458
>                 URL: https://issues.apache.org/jira/browse/HBASE-26458
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.4.8, 1.7.1
>            Reporter: Joel Swiatek
>            Priority: Minor
>             Fix For: 2.4.8, 1.7.1
>
>         Attachments: 0001-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defaulting.patch
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> When creating a snapshot, users can explicitly specify the TTL to be used. If no TTL is specified, then the SnapshotDescription is initially created with a TTL of -1 to indicate FOREVER.
> When the SnapshotDescription runs through SnapshotDescriptionUtils#validate, the TTL is checked to see if the default value of hbase.master.snapshot.ttl should be applied. The value from the config is only applied if the TTL == 0, but it should be -1.
> This has another nasty side-effect: any user who creates a snapshot and explicitly sets \{TTL => 0} will find that their snapshot gets its TTL from hbase.master.snapshot.TTL.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)