You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sa...@apache.org on 2020/12/13 13:10:19 UTC
[spark] branch branch-2.4 updated: [MINOR][UI] Correct JobPage's
skipped/pending tableHeaderId
This is an automated email from the ASF dual-hosted git repository.
sarutak pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new abded89 [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
abded89 is described below
commit abded89e368ff59e5d1894287dba7c8cc4c86082
Author: linzebing <li...@gmail.com>
AuthorDate: Sun Dec 13 22:00:05 2020 +0900
[MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
### What changes were proposed in this pull request?
Current Spark Web UI job page's header link of pending/skipped stages is inconsistent with their statuses. See the picture below:
### Why are the changes needed?
The code determining the `pendingOrSkippedTableId` has the wrong logic. As explained in the code:
> If the job is completed, then any pending stages are displayed as "skipped" [code pointer](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala#L266)
This PR fixes the logic for `pendingOrSkippedTableId` which aligns with the stage statuses.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Verified that header link is consistent with stage status with the fix.
Closes #30749 from linzebing/ui_bug.
Authored-by: linzebing <li...@gmail.com>
Signed-off-by: Kousuke Saruta <sa...@oss.nttdata.com>
(cherry picked from commit 0277fddaef17b615354c735a2c89cdced5f1d8f6)
Signed-off-by: Kousuke Saruta <sa...@oss.nttdata.com>
---
core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala
index 33391bb..33d8f04 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala
@@ -243,9 +243,9 @@ private[ui] class JobPage(parent: JobsTab, store: AppStatusStore) extends WebUIP
val pendingOrSkippedTableId =
if (isComplete) {
- "pending"
- } else {
"skipped"
+ } else {
+ "pending"
}
val activeStagesTable =
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org