You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by go...@apache.org on 2025/05/23 07:25:49 UTC
(pinot) branch revert-15737-segment-spi/implementation created (now a0cc5ee48d)
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a change to branch revert-15737-segment-spi/implementation
in repository https://gitbox.apache.org/repos/asf/pinot.git
at a0cc5ee48d Revert "Japicmp implementation in pinot-segment-spi (#15737)"
This branch includes the following new commits:
new a0cc5ee48d Revert "Japicmp implementation in pinot-segment-spi (#15737)"
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
(pinot) 01/01: Revert "Japicmp implementation in pinot-segment-spi (#15737)"
Posted by go...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch revert-15737-segment-spi/implementation
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit a0cc5ee48d2ef819d4b6dcb9561962dbad8497bc
Author: Gonzalo Ortiz Jaureguizar <go...@users.noreply.github.com>
AuthorDate: Fri May 23 09:25:40 2025 +0200
Revert "Japicmp implementation in pinot-segment-spi (#15737)"
This reverts commit 05b8fad2a33a13725d6fd35c9a72c06c43991669.
---
pinot-segment-spi/pom.xml | 63 ---------------------
.../pinot-segment-spi-japicmp-baseline.jar | Bin 337822 -> 0 bytes
pinot-spi/pom.xml | 8 +--
3 files changed, 4 insertions(+), 67 deletions(-)
diff --git a/pinot-segment-spi/pom.xml b/pinot-segment-spi/pom.xml
index 64363c3199..1c0dc9e176 100644
--- a/pinot-segment-spi/pom.xml
+++ b/pinot-segment-spi/pom.xml
@@ -34,69 +34,6 @@
<pinot.root>${basedir}/..</pinot.root>
</properties>
- <build>
- <plugins>
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
- <version>0.23.1</version>
- <configuration>
- <!-- If oldVersion were left blank, 1.3.0 would be the baseline version for japicmp's comparing. However, we already
- introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so we are using a baseline .jar of the repo here
- (with version as of PR #15737).
- TODO: At the time of the next Pinot release (1.4.0), update the baseline version here to 1.4.0 and remove pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar from repo.-->
- <oldVersion>
- <file>
- <path>${basedir}/resources/pinot-segment-spi-japicmp-baseline.jar</path>
- </file>
- </oldVersion>
- <newVersion>
- <file>
- <path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
- </file>
- </newVersion>
- <parameter>
- <includes>org.apache.pinot.segment.spi</includes>
- <onlyModified>true</onlyModified>
- <skipXmlReport>true</skipXmlReport>
- <skipHtmlReport>true</skipHtmlReport>
- <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
- <overrideCompatibilityChangeParameters>
- <overrideCompatibilityChangeParameter>
- <compatibilityChange>METHOD_NOW_VARARGS</compatibilityChange>
- <sourceCompatible>false</sourceCompatible>
- </overrideCompatibilityChangeParameter>
- <overrideCompatibilityChangeParameter>
- <compatibilityChange>METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE</compatibilityChange>
- <sourceCompatible>true</sourceCompatible>
- </overrideCompatibilityChangeParameter>
- <overrideCompatibilityChangeParameter>
- <compatibilityChange>METHOD_ABSTRACT_ADDED_IN_SUPERCLASS</compatibilityChange>
- <sourceCompatible>true</sourceCompatible>
- </overrideCompatibilityChangeParameter>
- <overrideCompatibilityChangeParameter>
- <compatibilityChange>METHOD_ABSTRACT_ADDED_TO_CLASS</compatibilityChange>
- <sourceCompatible>true</sourceCompatible>
- </overrideCompatibilityChangeParameter>
- <overrideCompatibilityChangeParameter>
- <compatibilityChange>METHOD_ADDED_TO_INTERFACE</compatibilityChange>
- <sourceCompatible>true</sourceCompatible>
- </overrideCompatibilityChangeParameter>
- </overrideCompatibilityChangeParameters>
- </parameter>
- </configuration>
- <executions>
- <execution>
- <phase>verify</phase>
- <goals>
- <goal>cmp</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
-
<dependencies>
<dependency>
<groupId>org.apache.pinot</groupId>
diff --git a/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar b/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar
deleted file mode 100644
index 566ebe05de..0000000000
Binary files a/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar and /dev/null differ
diff --git a/pinot-spi/pom.xml b/pinot-spi/pom.xml
index 3d1910754f..c5b2b71a89 100644
--- a/pinot-spi/pom.xml
+++ b/pinot-spi/pom.xml
@@ -129,15 +129,15 @@
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.23.1</version>
<configuration>
- <!-- If oldVersion were left blank, 1.3.0 would be the baseline version for japicmp's comparing. However, we already
- introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so we are using a baseline .jar of the repo here
- (with version as of PR #15684).
- TODO: At the time of the next Pinot release (1.4.0), update the baseline version here to 1.4.0 and remove pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
<oldVersion>
<file>
<path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
</file>
</oldVersion>
+<!-- If oldVersion were left blank, 1.3.0 would be the baseline version for japicmp's comparing. However, we already
+introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so we are using a baseline .jar of the repo here
+(with version as of PR #15684).
+TODO: At the time of the next Pinot release (1.4.0), update the baseline version here to 1.4.0 and remove pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
<newVersion>
<file>
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org