You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (Jira)" <ji...@apache.org> on 2020/03/06 15:22:00 UTC
[jira] [Resolved] (SLING-9175) TeleporterHttpClient should set
HttpURLConnection timeouts
[ https://issues.apache.org/jira/browse/SLING-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz resolved SLING-9175.
----------------------------------------
Assignee: Bertrand Delacretaz
Resolution: Fixed
At commit 5ace819 I have added HTTP connect and read timeouts that default to the same value as the "test ready" timeout.
The HTTP timeouts can be set to a specific value with the new {{ClientSideTeleporter.setHttpTimeoutSeconds}} method, which is typically used by {{TeleporterRule.Customizer}} classes as described at https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html
I have also added a bunch of debug log statements to the {{TeleporterHttpClient}}.
> TeleporterHttpClient should set HttpURLConnection timeouts
> ----------------------------------------------------------
>
> Key: SLING-9175
> URL: https://issues.apache.org/jira/browse/SLING-9175
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Affects Versions: JUnit Tests Teleporter 1.0.18
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Major
>
> The teleporter client uses {{HttpURLConnection}} in several places but doesn't set timeouts on those connections.
> It should set both read + connect timeouts to avoid using the default values which as per https://stackoverflow.com/questions/45199702/httpurlconnection-timeout-defaults and https://bluxte.net/musings/2008/08/25/dont-forget-set-javaneturl-default-timeouts/ (haven't found official docs for that) is infinite.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)