[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Jun/in and not in predicates

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #357: Jun/in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r311673642
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
 ##########
 @@ -62,10 +95,10 @@ public String toString() {
         return String.valueOf(ref()) + " == " + literal();
       case NOT_EQ:
         return String.valueOf(ref()) + " != " + literal();
-//      case IN:
-//        break;
-//      case NOT_IN:
-//        break;
+      case IN:
+        return String.valueOf(ref()) + " in " + literalSet();
 
 Review comment:
   I think this should add parentheses around the set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org