You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/21 10:00:19 UTC
[GitHub] [rocketmq] SparkLee opened a new pull request, #4860: add missing assertions of some test cases
SparkLee opened a new pull request, #4860:
URL: https://github.com/apache/rocketmq/pull/4860
add missing assertions of some test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SparkLee closed pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
SparkLee closed pull request #4860: add missing assertions of some test cases
URL: https://github.com/apache/rocketmq/pull/4860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4860:
URL: https://github.com/apache/rocketmq/pull/4860#issuecomment-1221836734
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4860](https://codecov.io/gh/apache/rocketmq/pull/4860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b70f48f) into [develop](https://codecov.io/gh/apache/rocketmq/commit/96fd4f52e09536e2e8487c701cc7846b0529b04e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96fd4f5) will **decrease** coverage by `1.29%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #4860 +/- ##
=============================================
- Coverage 44.80% 43.50% -1.30%
- Complexity 7637 7661 +24
=============================================
Files 982 982
Lines 68253 68253
Branches 9023 9023
=============================================
- Hits 30580 29693 -887
- Misses 33884 34825 +941
+ Partials 3789 3735 -54
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rocketmq/test/client/rmq/RMQBroadCastConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUUJyb2FkQ2FzdENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/rocketmq/test/message/MessageQueueMsg.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9tZXNzYWdlL01lc3NhZ2VRdWV1ZU1zZy5qYXZh) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| [...ava/org/apache/rocketmq/test/util/RandomUtils.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1JhbmRvbVV0aWxzLmphdmE=) | `0.00% <0.00%> (-92.86%)` | :arrow_down: |
| [...etmq/test/listener/rmq/order/RMQOrderListener.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9saXN0ZW5lci9ybXEvb3JkZXIvUk1RT3JkZXJMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [...est/listener/rmq/concurrent/RMQNormalListener.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9saXN0ZW5lci9ybXEvY29uY3VycmVudC9STVFOb3JtYWxMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (-80.77%)` | :arrow_down: |
| [...he/rocketmq/test/client/rmq/RMQNormalProducer.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUU5vcm1hbFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (-80.62%)` | :arrow_down: |
| [...rocketmq/test/client/rmq/RMQAsyncSendProducer.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUUFzeW5jU2VuZFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (-80.51%)` | :arrow_down: |
| [...pache/rocketmq/test/client/rmq/RMQSqlConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUVNxbENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...a/org/apache/rocketmq/test/factory/TagMessage.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9mYWN0b3J5L1RhZ01lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-74.47%)` | :arrow_down: |
| [...pache/rocketmq/test/listener/AbstractListener.java](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9saXN0ZW5lci9BYnN0cmFjdExpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (-74.08%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/rocketmq/pull/4860/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #4860:
URL: https://github.com/apache/rocketmq/pull/4860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SparkLee commented on pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
SparkLee commented on PR #4860:
URL: https://github.com/apache/rocketmq/pull/4860#issuecomment-1221730318
> Hi @SparkLee ,
>
> Don't forget to import the corresponding package for your changes.
It's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SparkLee commented on pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
SparkLee commented on PR #4860:
URL: https://github.com/apache/rocketmq/pull/4860#issuecomment-1221786811
> > Hi @SparkLee ,
> > Don't forget to import the corresponding package for your changes.
>
> It's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing commented on a diff in pull request #4860: add missing assertions of some test cases
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #4860:
URL: https://github.com/apache/rocketmq/pull/4860#discussion_r951145689
##########
acl/src/test/java/org/apache/rocketmq/acl/common/AclSignerTest.java:
##########
@@ -27,8 +28,9 @@ public void calSignatureExceptionTest(){
@Test
public void calSignatureTest(){
- AclSigner.calSignature("RocketMQ","12345678");
- AclSigner.calSignature("RocketMQ".getBytes(),"12345678");
+ String expectedSignature = "IUc8rrO/0gDch8CjObLQsW2rsiA=";
+ Assert.assertEquals(expectedSignature, AclSigner.calSignature("RocketMQ", "12345678"));
+ Assert.assertEquals(expectedSignature, AclSigner.calSignature("RocketMQ".getBytes(), "12345678"));
Review Comment:
Assert.assertEquals(AclSigner.calSignature("RocketMQ", "12345678"), AclSigner.calSignature("RocketMQ".getBytes(), "12345678"));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org