[GitHub] [arrow] dinimar commented on a diff in pull request #34537: GH-14939: [C++] Support Table lookups in FieldRef and FieldPath

["dinimar (via GitHub)" <gi...@apache.org>]

dinimar commented on code in PR #34537:
URL: https://github.com/apache/arrow/pull/34537#discussion_r1155933703


##########
cpp/src/arrow/type.cc:
##########
@@ -1216,6 +1321,18 @@ Result<std::shared_ptr<ArrayData>> FieldPath::Get(const ArrayData& data) const {
   return FieldPathGetImpl::Get(this, data.child_data);
 }
 
+Result<std::shared_ptr<ChunkedArray>> FieldPath::Get(
+    const ChunkedArray& chunked_array) const {
+  if (chunked_array.num_chunks() < 1) {
+    return Status::Invalid("Chunked array must have at least one chunk");

Review Comment:
   @benibus please resolve this converstion. At the moment, it's the last thing to be done before second review from Weston Pace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org