You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2014/02/13 02:09:54 UTC
[Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+--------------------
Reporter: rjollos | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: multiproduct | Version:
Keywords: console admin |
---------------------------+--------------------
For example, omitting the //owner// argument (which is currently required,
but not after trac:#11344):
{{{#!sh
$ trac-admin $env product admin prod5 component add component5
Error: Invalid arguments
product admin <PREFIX> <admin command>
Execute admin (sub-)command upon product resources
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: closed
Priority: major | Milestone: Release 8
Component: multiproduct | Version:
Resolution: fixed | Keywords: console admin
---------------------------+---------------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
(In [1572374])
0.8dev: Added tests for output of help when `trac-admin` is called at
product-scope with improper arguments. Refs #756.
----
(In [1572376])
0.8dev: Fix for help not being output when `trac-admin` commands are
called at product scope with incorrect arguments. Refs #756.
Patch by Olemis Lang.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: closed
Priority: major | Milestone: Release 8
Component: multiproduct | Version:
Resolution: fixed | Keywords: console admin
---------------------------+---------------------------
Comment (by rjollos):
Replying to [comment:3 olemis]:
> Open question :
>
> - Should suggested command be «product admin <prefix> <sub-command>» ?
We may want to consider this in #764.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Olemis Lang <ol...@gmail.com>.
On Fri, Feb 21, 2014 at 4:48 PM, Ryan Ollos <ry...@wandisco.com> wrote:
> On Fri, Feb 21, 2014 at 9:38 AM, Olemis Lang <ol...@gmail.com> wrote:
>
> > On Feb 20, 2014 9:31 PM, "Ryan Ollos" <ry...@wandisco.com> wrote:
> > >
> > > On Thu, Feb 13, 2014 at 2:18 PM, Apache Bloodhound <
> > > dev@bloodhound.apache.org> wrote:
> > >
> > [...]
> > > >
> > > >
> > > > Comment:
> > > >
> > > > Test cases needed ...
> > > >
> > >
> > > Do you plan to add a test case for this ticket, and #757?
> > >
> >
> > I was just waiting for feedback. Everything ok?
>
>
> Yeah, it fixed the issue for me.
>
Ok , I already have written the test cases but I'm I'm currently debugging
because there's been an unforeseen event . For some reason , the trac admin
console class detects that an update is required , thus leading to failure
... will keep you updated .
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Ryan Ollos <ry...@wandisco.com>.
On Fri, Feb 21, 2014 at 9:38 AM, Olemis Lang <ol...@gmail.com> wrote:
> On Feb 20, 2014 9:31 PM, "Ryan Ollos" <ry...@wandisco.com> wrote:
> >
> > On Thu, Feb 13, 2014 at 2:18 PM, Apache Bloodhound <
> > dev@bloodhound.apache.org> wrote:
> >
> [...]
> > >
> > >
> > > Comment:
> > >
> > > Test cases needed ...
> > >
> >
> > Do you plan to add a test case for this ticket, and #757?
> >
>
> I was just waiting for feedback. Everything ok?
Yeah, it fixed the issue for me.
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Olemis Lang <ol...@gmail.com>.
On Feb 20, 2014 9:31 PM, "Ryan Ollos" <ry...@wandisco.com> wrote:
>
> On Thu, Feb 13, 2014 at 2:18 PM, Apache Bloodhound <
> dev@bloodhound.apache.org> wrote:
>
[...]
> >
> >
> > Comment:
> >
> > Test cases needed ...
> >
>
> Do you plan to add a test case for this ticket, and #757?
>
I was just waiting for feedback. Everything ok?
> There is still quite a bit to finish for Release 8, so if you could take
> care of adding the test case that would help me quite a bit
Sure! I'll submit later today
> https://issues.apache.org/bloodhound/milestone/Release%208
>
> We could also use a test case for #750, but that's lower priority and
> appears to require quite a bit more effort.
> https://issues.apache.org/bloodhound/ticket/750
Yeah, maybe for Release 9. There is a ticket for that #567 , should you
choose adding a note for us to remember
Sent from Android
--
Regards
Olemis - @olemislc
Blog-ES : http://simelo-es.blogspot.com
Blog-EN : http://simelo-en.blogspot.com
Projects : http://blood-hound.net
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Ryan Ollos <ry...@wandisco.com>.
On Thu, Feb 13, 2014 at 2:18 PM, Apache Bloodhound <
dev@bloodhound.apache.org> wrote:
> #756: Unhelpful errors from product-scoped commands in console admin
> ---------------------------+---------------------------
> Reporter: rjollos | Owner: rjollos
> Type: enhancement | Status: review
> Priority: major | Milestone: Release 9
> Component: multiproduct | Version:
> Resolution: | Keywords: console admin
> ---------------------------+---------------------------
> Changes (by olemis):
>
> * owner: olemis => rjollos
> * status: accepted => review
>
>
> Comment:
>
> Test cases needed ...
>
Do you plan to add a test case for this ticket, and #757?
There is still quite a bit to finish for Release 8, so if you could take
care of adding the test case that would help me quite a bit.
https://issues.apache.org/bloodhound/milestone/Release%208
We could also use a test case for #750, but that's lower priority and
appears to require quite a bit more effort.
https://issues.apache.org/bloodhound/ticket/750
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 9
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Changes (by olemis):
* owner: olemis => rjollos
* status: accepted => review
Comment:
Test cases needed ...
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Ryan Ollos <ry...@wandisco.com>.
On Sat, Feb 22, 2014 at 11:01 AM, Apache Bloodhound <
dev@bloodhound.apache.org> wrote:
> #756: Unhelpful errors from product-scoped commands in console admin
> ---------------------------+---------------------------
> Reporter: rjollos | Owner: rjollos
> Type: enhancement | Status: review
> Priority: major | Milestone: Release 8
> Component: multiproduct | Version:
> Resolution: | Keywords: console admin
> ---------------------------+---------------------------
>
> Comment (by olemis):
>
> Added patches for #756 and #757 including test cases for both enhancements
> . Details :
>
> {{{#!sh
>
> $ hg qapplied
> t756_r1567795_product_admin_failmsg.diff
> t756_r1567795_product_admin_failmsg.tests.diff
> t757_r1570616_product_help.tests.diff
>
> }}}
>
> @rjollos : please review .
>
> p.s. `tests.env` module has been modified in order to run TracAdmin
> commands bound to the global env without getting ''Trac environment needs
> to be upgraded'' error message .
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:6>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker
>
Some additional issues were discovered while investigating, and they have
been captured in the following tickets:
https://issues.apache.org/bloodhound/ticket/762
https://issues.apache.org/bloodhound/ticket/764
https://issues.apache.org/bloodhound/ticket/768
https://issues.apache.org/bloodhound/ticket/771
I'm still working on outlining planned changes in #771, so more information
is forthcoming in that ticket.
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 8
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Comment (by olemis):
Added patches for #756 and #757 including test cases for both enhancements
. Details :
{{{#!sh
$ hg qapplied
t756_r1567795_product_admin_failmsg.diff
t756_r1567795_product_admin_failmsg.tests.diff
t757_r1570616_product_help.tests.diff
}}}
@rjollos : please review .
p.s. `tests.env` module has been modified in order to run TracAdmin
commands bound to the global env without getting ''Trac environment needs
to be upgraded'' error message .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 9
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Comment (by olemis):
Attached patch is aimed at improving error messages when product admin
commands are executed .
This is a typical trac-admin session in product context
{{{#!sh
$ trac-admin /path/to/trac/env/
Welcome to trac-admin 1.0.1
Interactive Trac administration console.
Copyright (C) 2003-2013 Edgewall Software
Type: '?' or 'help' for help on commands.
Trac [/path/to/trac/env]> product admin default component add c3
Error: Invalid arguments
Admin command failed in product : default
component add <name> <owner>
Add a new component
}}}
Details :
{{{#!sh
$ hg qapplied
t756/t756_r1567795_product_admin_failmsg.diff
$ hg log -r qparent --template="{svnrev}\n"
1567795
}}}
Open question :
- Should suggested command be «product admin <prefix> <sub-command>» ?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: closed
Priority: major | Milestone: Release 8
Component: multiproduct | Version:
Resolution: fixed | Keywords: console admin
---------------------------+---------------------------
Changes (by rjollos):
* owner: rjollos => olemis
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 9
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Changes (by olemis):
* owner: nobody => olemis
* status: new => accepted
* type: defect => enhancement
* milestone: => Release 9
Comment:
I'll start working on this with an initial schedule for
[milestone:"Release 9"] but maybe ready sooner than that ... depending on
scheduled release deadline for [milestone:"Release 8"] .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 8
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Changes (by rjollos):
* milestone: Release 9 => Release 8
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #756: Unhelpful errors from product-scoped
commands in console admin
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#756: Unhelpful errors from product-scoped commands in console admin
---------------------------+---------------------------
Reporter: rjollos | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 9
Component: multiproduct | Version:
Resolution: | Keywords: console admin
---------------------------+---------------------------
Comment (by olemis):
Replying to [ticket:756 rjollos]:
> For example, omitting the //owner// argument (which is currently
required, but not after trac:#11344):
The updates in the trac-admin command itself are beyond the scope of this
ticket and will be merged into /trunk once the corresponding Trac branch
will be updated in our vendor branch .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/756#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker