You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/12 15:08:31 UTC
[GitHub] [hudi] codope opened a new pull request, #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
codope opened a new pull request, #6657:
URL: https://github.com/apache/hudi/pull/6657
JDK versions 16 or later enforce strong encapsulation and do now allow to invoke `setAccessible` on a field, especially when the `isAccessible` is false. More details in [JEP 403](https://openjdk.org/jeps/403). This PR attempts to address that for `ObjectSizeCalculator`. An immediate use case where this would be beneficial is integrating Hudi with other libraries, e.g. Trino, that are using higher versions of JDK.
We evaluated two other approaches:
1. Get the object size base on the amount of byte serialized. However, this runs into error if the incoming object does not implement `Serializable`.
2. Use Java's [Instrumentation](https://docs.oracle.com/en/java/javase/11/docs/api/java.instrument/java/lang/instrument/Instrumentation.html) API. For this, we need to create an instrumentation agent that can be hooked to the JVM. If Hudi was a standalone project, then we could have taken but since Hudi is integrated into other projects as well, we need to invest some time to figure out how to hook our instrumentation agent into those running JVMs.
### Change Logs
* If fields are accessible, run the usual code.
* Else, use Java Object Layout ([JOL](https://github.com/openjdk/jol)) to get object size.
* Add test with different types of objects.
### Impact
High.
This PR makes changes in `ObjectSizeEstimator`, which is on the hot path.
**Risk level: none | low | medium | high**
High.
Tests have been added to cover various types of objects, both serializable and no serializable.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1243928882
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 552bc2eb56ce188976ff871130ec7d576f20e670 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1244012617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 552bc2eb56ce188976ff871130ec7d576f20e670 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1259620308
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 0f723714f4d30d0da445a5c03be8c0c8b16e25e1 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789)
* 23928b7db6d79929b01df68d2b6e1d892263223b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1259515521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736)
* 0f723714f4d30d0da445a5c03be8c0c8b16e25e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
codope merged PR #6657:
URL: https://github.com/apache/hudi/pull/6657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r980500200
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java:
##########
@@ -188,7 +188,7 @@ public void testUpsertWithDelete() throws Exception {
@Test
public void testInsertWithMiniBatches() throws Exception {
// reset the config option
- conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.0008); // 839 bytes batch size
+ conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.00008); // 839 bytes batch size
Review Comment:
Just for my own education: why did we need to change this?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -127,6 +129,16 @@ public synchronized long calculateObjectSize(Object obj) {
}
obj = pending.removeFirst();
}
+ } catch (IllegalAccessException | SecurityException e) {
+ // JDK versions 16 or later enforce strong encapsulation and do now allow to invoke `setAccessible` on a field,
+ // especially when the `isAccessible` is false. More details in JEP 403. While integrating Hudi with other
+ // software packages that compile against JDK 16 or later (e.g. Trino), the IllegalAccessException will be thrown.
+ // In that case, we use Java Object Layout (JOL) to estimate the object size.
+ //
+ // NOTE: We cannot get the object size base on the amount of byte serialized because there is no guarantee
+ // that the incoming object is serializable. We could have used Java's Instrumentation API but it
+ // needs an instrumentation agent that can be hooked to the JVM. In lieu of that, we are using JOL.
+ return ClassLayout.parseClass(obj.getClass()).instanceSize();
Review Comment:
@codope is there a reason we wouldn't want to use JOL to replace this impl?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -127,6 +129,16 @@ public synchronized long calculateObjectSize(Object obj) {
}
obj = pending.removeFirst();
}
+ } catch (IllegalAccessException | SecurityException e) {
+ // JDK versions 16 or later enforce strong encapsulation and do now allow to invoke `setAccessible` on a field,
Review Comment:
Typo: "not"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1256253567
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* d9065c5bb2385b75c00b4bb244bfedfcb7d9f858 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356)
* 61105c1b9b8db212e5d7b99a28f9c91094f940be UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
codope commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1260585243
> I'm a little worried about JOLs performance though, so would be great if we can write simple JMH based micro-benchmark for it and compare it against what we had before (we can do it after release branch cut).
Good point! I am going to take that up soon. HUDI-4943.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1247164755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* d9065c5bb2385b75c00b4bb244bfedfcb7d9f858 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r981255335
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java:
##########
@@ -188,7 +188,7 @@ public void testUpsertWithDelete() throws Exception {
@Test
public void testInsertWithMiniBatches() throws Exception {
// reset the config option
- conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.0008); // 839 bytes batch size
+ conf.setDouble(FlinkOptions.WRITE_BATCH_SIZE, 0.00008); // 839 bytes batch size
Review Comment:
Hey, this is a good point! Previously, I thought the object sizes were being overestimated. But, then I actually looked into the records and I realized this JOL CLassLayout is under-estimating. It's giving a shallow size. So, we have got to use GraphLayout to get the deep size (including the size of objects that are being referenced from the current object). I'll update the patch soon after doing some more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1243935641
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 552bc2eb56ce188976ff871130ec7d576f20e670 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1246468525
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 552bc2eb56ce188976ff871130ec7d576f20e670 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304)
* d9065c5bb2385b75c00b4bb244bfedfcb7d9f858 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r978684984
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -232,7 +240,7 @@ private class ClassSizeInfo {
private final long fieldsSize;
private final Field[] referenceFields;
- public ClassSizeInfo(Class<?> clazz) {
+ public ClassSizeInfo(Class<?> clazz, int referenceSize, int superclassFieldPadding, int objectHeaderSize, int objectPadding) {
Review Comment:
I wanted to make `ClassSizeInfo` static so had to pass these member variables of `ObjectSizeCalculator` as ctor args. I have reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r971328667
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -127,23 +129,29 @@ public synchronized long calculateObjectSize(Object obj) {
}
obj = pending.removeFirst();
}
+ } catch (IllegalAccessException | SecurityException e) {
Review Comment:
Let's add a comment elaborating on fallback (basically what you've put up in a description here)
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -232,7 +240,7 @@ private class ClassSizeInfo {
private final long fieldsSize;
private final Field[] referenceFields;
- public ClassSizeInfo(Class<?> clazz) {
+ public ClassSizeInfo(Class<?> clazz, int referenceSize, int superclassFieldPadding, int objectHeaderSize, int objectPadding) {
Review Comment:
Where are these new fields used? I see them passed t/h, but don't see them being actually used anywhere
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestObjectSizeCalculator.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.util;
+
+import org.apache.hudi.common.model.HoodieRecord;
+
+import org.apache.avro.Schema;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+public class TestObjectSizeCalculator {
+
+ @Test
+ public void testGetObjectSize() {
+ EmptyClass emptyClass = new EmptyClass();
+ StringClass stringClass = new StringClass();
+ PayloadClass payloadClass = new PayloadClass();
+ String emptyString = "";
+ String string = "hello";
+ String[] stringArray = {emptyString, string, " world"};
+ String[] anotherStringArray = new String[100];
+ List<String> stringList = new ArrayList<>();
+ StringBuilder stringBuilder = new StringBuilder(100);
+ int maxIntPrimitive = Integer.MAX_VALUE;
+ int minIntPrimitive = Integer.MIN_VALUE;
+ Integer maxInteger = Integer.MAX_VALUE;
+ Integer minInteger = Integer.MIN_VALUE;
+ long zeroLong = 0L;
+ double zeroDouble = 0.0;
+ boolean booleanField = true;
+ Object object = new Object();
+
+ Assertions.assertDoesNotThrow(() -> {
+ printObjectSize(emptyString);
Review Comment:
Let's actually assert objects' sizes instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1256260110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* d9065c5bb2385b75c00b4bb244bfedfcb7d9f858 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356)
* 61105c1b9b8db212e5d7b99a28f9c91094f940be Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1258171311
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1243921689
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1259508071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736)
* 0f723714f4d30d0da445a5c03be8c0c8b16e25e1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1256414330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 61105c1b9b8db212e5d7b99a28f9c91094f940be Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1256412070
cancelling all azure CI runs for now to investigate CI flakiness. will retrigger build once we are in stable state. sorry about the inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1257791274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 61105c1b9b8db212e5d7b99a28f9c91094f940be Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635)
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1259612572
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736)
* 0f723714f4d30d0da445a5c03be8c0c8b16e25e1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789)
* 23928b7db6d79929b01df68d2b6e1d892263223b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1260368877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
}, {
"hash" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 23928b7db6d79929b01df68d2b6e1d892263223b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791)
* 1751ff401d075667a7acedde954a9b9c459ce7ef UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1261200338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
}, {
"hash" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11821",
"triggerID" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 1751ff401d075667a7acedde954a9b9c459ce7ef Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1246542582
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 552bc2eb56ce188976ff871130ec7d576f20e670 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304)
* d9065c5bb2385b75c00b4bb244bfedfcb7d9f858 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1257798221
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 61105c1b9b8db212e5d7b99a28f9c91094f940be Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635)
* f7cf0db66166a0302d1237539f60ce9e9e0a9ddc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6657:
URL: https://github.com/apache/hudi/pull/6657#discussion_r981256090
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java:
##########
@@ -127,6 +129,16 @@ public synchronized long calculateObjectSize(Object obj) {
}
obj = pending.removeFirst();
}
+ } catch (IllegalAccessException | SecurityException e) {
+ // JDK versions 16 or later enforce strong encapsulation and do now allow to invoke `setAccessible` on a field,
+ // especially when the `isAccessible` is false. More details in JEP 403. While integrating Hudi with other
+ // software packages that compile against JDK 16 or later (e.g. Trino), the IllegalAccessException will be thrown.
+ // In that case, we use Java Object Layout (JOL) to estimate the object size.
+ //
+ // NOTE: We cannot get the object size base on the amount of byte serialized because there is no guarantee
+ // that the incoming object is serializable. We could have used Java's Instrumentation API but it
+ // needs an instrumentation agent that can be hooked to the JVM. In lieu of that, we are using JOL.
+ return ClassLayout.parseClass(obj.getClass()).instanceSize();
Review Comment:
Actually, there is no strong reason. We can remove the older implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1259811908
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 23928b7db6d79929b01df68d2b6e1d892263223b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6657: [HUDI-4687] Avoid setAccessible which breaks strong encapsulation
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6657:
URL: https://github.com/apache/hudi/pull/6657#issuecomment-1260371724
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374",
"triggerType" : "PUSH"
}, {
"hash" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11304",
"triggerID" : "552bc2eb56ce188976ff871130ec7d576f20e670",
"triggerType" : "PUSH"
}, {
"hash" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11356",
"triggerID" : "d9065c5bb2385b75c00b4bb244bfedfcb7d9f858",
"triggerType" : "PUSH"
}, {
"hash" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11635",
"triggerID" : "61105c1b9b8db212e5d7b99a28f9c91094f940be",
"triggerType" : "PUSH"
}, {
"hash" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11736",
"triggerID" : "f7cf0db66166a0302d1237539f60ce9e9e0a9ddc",
"triggerType" : "PUSH"
}, {
"hash" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11789",
"triggerID" : "0f723714f4d30d0da445a5c03be8c0c8b16e25e1",
"triggerType" : "PUSH"
}, {
"hash" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791",
"triggerID" : "23928b7db6d79929b01df68d2b6e1d892263223b",
"triggerType" : "PUSH"
}, {
"hash" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11821",
"triggerID" : "1751ff401d075667a7acedde954a9b9c459ce7ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d7ad25b0513ac14d78d08b58c7bd0b4b0cf374 UNKNOWN
* 23928b7db6d79929b01df68d2b6e1d892263223b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11791)
* 1751ff401d075667a7acedde954a9b9c459ce7ef Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org