You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2013/10/20 01:32:37 UTC

svn commit: r1533843 - /lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java

Author: uschindler
Date: Sat Oct 19 23:32:37 2013
New Revision: 1533843

URL: http://svn.apache.org/r1533843
Log:
LUCENE-4956: Make filter final, add one more nocommit

Modified:
    lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java

Modified: lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java?rev=1533843&r1=1533842&r2=1533843&view=diff
==============================================================================
--- lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java (original)
+++ lucene/dev/branches/lucene4956/lucene/analysis/arirang/src/java/org/apache/lucene/analysis/ko/KoreanFilter.java Sat Oct 19 23:32:37 2013
@@ -42,7 +42,7 @@ import org.apache.lucene.analysis.tokena
 import org.apache.lucene.analysis.tokenattributes.PositionIncrementAttribute;
 import org.apache.lucene.analysis.tokenattributes.TypeAttribute;
 
-public class KoreanFilter extends TokenFilter {
+public final class KoreanFilter extends TokenFilter {
 
   private final LinkedList<IndexWord> morphQueue = new LinkedList<IndexWord>();;
   private final MorphAnalyzer morph = new MorphAnalyzer();
@@ -100,7 +100,7 @@ public class KoreanFilter extends TokenF
     this.isPositionInc = isPositionInc;
   }
   
-  public final boolean incrementToken() throws IOException {
+  public boolean incrementToken() throws IOException {
     if (!morphQueue.isEmpty()) {
       restoreState(currentState);
       setTermBufferByQueue();
@@ -139,9 +139,9 @@ public class KoreanFilter extends TokenF
     termAtt.setEmpty().append(word);
     offsetAtt.setOffset(iw.getOffset(), iw.getOffset() + word.length());
     
+    // NOCOMMIT: This is bullshit! PositionIncrement=0 if disabled?
     int inc = isPositionInc ?  iw.getIncrement() : 0;
     posIncrAtt.setPositionIncrement(inc);      
-    
   }
   
   /**