[GitHub] [hbase] leyangyueshan commented on a change in pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

[GitBox <gi...@apache.org>]

leyangyueshan commented on a change in pull request #2848:
URL: https://github.com/apache/hbase/pull/2848#discussion_r553081166



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java
##########
@@ -250,7 +250,12 @@ void updateStore(byte[] encodedRegionName, byte[] familyName, Long sequenceId,
    */
   private static long getLowestSequenceId(Map<?, Long> sequenceids) {
     long lowest = HConstants.NO_SEQNUM;
-    for (Long sid: sequenceids.values()) {
+    for (Map.Entry<? , Long> entry : sequenceids.entrySet()){
+      if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){
+        LOG.info("ColumnFamily is METAFAMILY! continue ...");

Review comment:
       no, I think.  delete it at a new commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org