You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/24 06:50:53 UTC
Review Request: Added more path::join variants.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7716/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/include/stout/path.hpp e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b
Diff: https://reviews.apache.org/r/7716/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added more path::join variants.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7716/
-----------------------------------------------------------
(Updated Oct. 26, 2012, 6:13 p.m.)
Review request for mesos, Vinod Kone and Ben Mahler.
Changes
-------
Updates from review comments.
Description
-------
See summary.
Diffs (updated)
-----
third_party/libprocess/include/stout/path.hpp e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b
Diff: https://reviews.apache.org/r/7716/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added more path::join variants.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 24, 2012, 9:07 p.m., Ben Mahler wrote:
> > third_party/libprocess/include/stout/path.hpp, line 56
> > <https://reviews.apache.org/r/7716/diff/1/?file=179348#file179348line56>
> >
> > Seems cleaner to do these all using the next biggest join:
> >
> > join(path1, join(path2, path3, path4, path5, path6));
Totally, done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7716/#review12723
-----------------------------------------------------------
On Oct. 24, 2012, 4:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7716/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 4:50 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/path.hpp e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b
>
> Diff: https://reviews.apache.org/r/7716/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added more path::join variants.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7716/#review12723
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/stout/path.hpp
<https://reviews.apache.org/r/7716/#comment27117>
Seems cleaner to do these all using the next biggest join:
join(path1, join(path2, path3, path4, path5, path6));
- Ben Mahler
On Oct. 24, 2012, 4:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7716/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 4:50 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/path.hpp e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b
>
> Diff: https://reviews.apache.org/r/7716/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>