You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/05/23 11:36:13 UTC
Review Request 59489: RANGER-1608 - SOLR resource lookup fails with
basic auth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59489/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1608
https://issues.apache.org/jira/browse/RANGER-1608
Repository: ranger
Description
-------
Currently, the SOLR connection test + subsequent resource lookup when creating policies fails when basic authentication is enabled in SOLR.
Diffs
-----
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java 880ec725
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java d8470a0b
Diff: https://reviews.apache.org/r/59489/diff/1/
Testing
-------
Tested connection + that we can pull down resources from a SOLR Cloud instance with basic auth enabled.
Thanks,
Colm O hEigeartaigh
Re: Review Request 59489: RANGER-1608 - SOLR resource lookup fails
with basic auth
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59489/#review176076
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 23, 2017, 11:36 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59489/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 11:36 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1608
> https://issues.apache.org/jira/browse/RANGER-1608
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the SOLR connection test + subsequent resource lookup when creating policies fails when basic authentication is enabled in SOLR.
>
>
> Diffs
> -----
>
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java 880ec725
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java d8470a0b
>
>
> Diff: https://reviews.apache.org/r/59489/diff/1/
>
>
> Testing
> -------
>
> Tested connection + that we can pull down resources from a SOLR Cloud instance with basic auth enabled.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 59489: RANGER-1608 - SOLR resource lookup fails
with basic auth
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 25, 2017, 9:58 a.m., Qiang Zhang wrote:
> > Looks good.
> > Have you tested your changes carefully?
> > I will also specifically test the issue when I have more time.
Well I verifed that it works with basic auth :-) I will hold off committing until you can test the fix as well - there's no rush.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59489/#review176053
-----------------------------------------------------------
On May 23, 2017, 11:36 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59489/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 11:36 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1608
> https://issues.apache.org/jira/browse/RANGER-1608
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the SOLR connection test + subsequent resource lookup when creating policies fails when basic authentication is enabled in SOLR.
>
>
> Diffs
> -----
>
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java 880ec725
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java d8470a0b
>
>
> Diff: https://reviews.apache.org/r/59489/diff/1/
>
>
> Testing
> -------
>
> Tested connection + that we can pull down resources from a SOLR Cloud instance with basic auth enabled.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 59489: RANGER-1608 - SOLR resource lookup fails
with basic auth
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59489/#review176053
-----------------------------------------------------------
Looks good.
Have you tested your changes carefully?
I will also specifically test the issue when I have more time.
- Qiang Zhang
On 五月 23, 2017, 11:36 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59489/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 11:36 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1608
> https://issues.apache.org/jira/browse/RANGER-1608
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the SOLR connection test + subsequent resource lookup when creating policies fails when basic authentication is enabled in SOLR.
>
>
> Diffs
> -----
>
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java 880ec725
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java d8470a0b
>
>
> Diff: https://reviews.apache.org/r/59489/diff/1/
>
>
> Testing
> -------
>
> Tested connection + that we can pull down resources from a SOLR Cloud instance with basic auth enabled.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>