You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/08/14 03:31:57 UTC

[GitHub] thinkerleolee opened a new pull request #2288: Supplementary unit test #2177 team6

thinkerleolee opened a new pull request #2288: Supplementary unit test #2177 team6
URL: https://github.com/apache/incubator-dubbo/pull/2288
 
 
   ## What is the purpose of the change
   
   Resolve #2177.
   
   ## Brief changelog
   
   The following branches have been Unit Tested:
   org.apache.dubbo.registry.support.AbstractRegistry#register
   org.apache.dubbo.registry.support.AbstractRegistry#unregister
   org.apache.dubbo.registry.support.AbstractRegistry#subscribe
   org.apache.dubbo.registry.support.AbstractRegistry#unsubscribe
   org.apache.dubbo.registry.support.AbstractRegistry#recover
   org.apache.dubbo.registry.support.AbstractRegistry#notify
   
   BaiJi training camp 269 Team No.6, Alibaba-Inc.
   
   ## Verifying this change
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [GITHUB_issue](https://github.com/apahe/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
   - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org