You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/06 23:25:26 UTC
[GitHub] [iceberg] wangmiao1981 opened a new pull request #1171: add gitignore items and improve code readability
wangmiao1981 opened a new pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171
Add a few items in gitignore;
For BaseSnapshot::cacheManifests, it code implies that deleteManifests will always be set. This change is just to explicitly set deleteManifests if it is null to increase code readability.
Tests: Existing UTs in Core. No need for new UTs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1171: add gitignore items and improve code readability
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171#issuecomment-655000585
@wangmiao1981, could you separate these into different PRs? We try to keep changes focused on just one problem so that they can be cherry-picked between branches without unnecessary git conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1171: improve code readability
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1171: add gitignore items and improve code readability
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171#discussion_r451015288
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -130,6 +130,9 @@ private void cacheManifests() {
if (dataManifests == null) {
this.dataManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
manifest -> manifest.content() == ManifestContent.DATA));
+ }
+
+ if (deleteManifests == null) {
Review comment:
What about using `dataManifests == null || deleteManifests == null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wangmiao1981 commented on pull request #1171: add gitignore items and improve code readability
Posted by GitBox <gi...@apache.org>.
wangmiao1981 commented on pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171#issuecomment-655134321
I will make the change to 2 PRs. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1171: improve code readability
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1171:
URL: https://github.com/apache/iceberg/pull/1171#issuecomment-655667194
Merged. Thanks @wangmiao1981!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org