[Impala-ASF-CR] IMPALA-5350: Tidy up thread groups for finst exec threads

["Dan Hecht (Code Review)" <ge...@cloudera.org>]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:

PS2, Line 232: &FragmentInstanceState::ReportProfileThread, this
you rewrote the other cases to use a lambda here. i don't have a strong preference either way, but just wondering if there's a reason for the inconsistency?


http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

PS2, Line 303: &QueryState::ExecFInstance, this, fis
same


-- 
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes