You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dvorst (via GitHub)" <gi...@apache.org> on 2024/10/10 12:54:04 UTC
[PR] Doc: Fix required java versions for spark 3.5 [spark]
dvorst opened a new pull request, #48411:
URL: https://github.com/apache/spark/pull/48411
The original description "PySpark requires Java 8 or later" is incorrect since 3.5 does not support java 8 anymore and the latest supported version is 17, the downloading page however, does correctly state this. I thus corrected the mentioned java versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Doc: Fix required java versions for spark 3.5 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48411:
URL: https://github.com/apache/spark/pull/48411#issuecomment-2408334364
Current changes are fine to me, but please do not disrupt the template for the [r description, every item must be filled out, and the title of the pr should also adhere to the standard format. And are there any other cases where the description of Java 8 versions is not accurate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS][3.5] Fix specified java versions in `install.rst` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #48411: [MINOR][DOCS][3.5] Fix specified java versions in `install.rst`
URL: https://github.com/apache/spark/pull/48411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Doc: Fix required java versions for spark 3.5 [spark]
Posted by "dvorst (via GitHub)" <gi...@apache.org>.
dvorst commented on PR #48411:
URL: https://github.com/apache/spark/pull/48411#issuecomment-2406735665
The following is mentioned on the downloadings page (https://spark.apache.org/docs/3.5.3/#downloading)
> Java 8 prior to version 8u371 support is deprecated as of Spark 3.5.0
For some reason, I misread this and was under the impression that support for Java 8 was deprecated in its entirety as of 3.5.0.
I added a new commit where I updated the documentation and included Java 8 back in, with an exception for versions prior to 8u371.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [DOCS]Fix specified java versions for spark 3.5 in `python/docs/source/getting_started/install.rst` [spark]
Posted by "dvorst (via GitHub)" <gi...@apache.org>.
dvorst commented on PR #48411:
URL: https://github.com/apache/spark/pull/48411#issuecomment-2413237615
Apologies, I updated the PR's title and description, reincorporating the template. If the initial removal of the template is causing issues, I can also close this PR and reopen one with the same changes. If the title/description is still not up to standard, I'm happy to change it to meet the requirements.
I also enabled workflows on my repository, which was causing the build to fail.
Lastly, to answer your question, I haven't run into any cases thus far where the description of Java 8 version is inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org