You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/02/01 07:48:40 UTC
Review Request: fixed issue with listegressfirewallrules api
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9236/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fixed issue with the network id in listegressfirewallrules api.
Changed the parameter commandtype to uuid
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java 4646cdb
api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java 6eeb536
Diff: https://reviews.apache.org/r/9236/diff/
Testing
-------
Unit tested:
list and delete egress firewall rules from UI
Thanks,
Jayapal Reddy
Re: Review Request: fixed issue with listegressfirewallrules api
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9236/#review15994
-----------------------------------------------------------
Ship it!
Ship It!
- Murali Reddy
On Feb. 1, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9236/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixed issue with the network id in listegressfirewallrules api.
> Changed the parameter commandtype to uuid
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java 4646cdb
> api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java 6eeb536
>
> Diff: https://reviews.apache.org/r/9236/diff/
>
>
> Testing
> -------
>
> Unit tested:
> list and delete egress firewall rules from UI
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: fixed issue with listegressfirewallrules api
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9236/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 8:32 a.m.)
Review request for cloudstack.
Changes
-------
added account entity type.
Description
-------
Fixed issue with the network id in listegressfirewallrules api.
Changed the parameter commandtype to uuid
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java 4646cdb
api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java 6eeb536
Diff: https://reviews.apache.org/r/9236/diff/
Testing
-------
Unit tested:
list and delete egress firewall rules from UI
Thanks,
Jayapal Reddy
Re: Review Request: fixed issue with listegressfirewallrules api
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9236/#review15992
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java
<https://reviews.apache.org/r/9236/#comment34293>
need entity type here as well
- Murali Reddy
On Feb. 1, 2013, 6:48 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9236/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixed issue with the network id in listegressfirewallrules api.
> Changed the parameter commandtype to uuid
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java 4646cdb
> api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java 6eeb536
>
> Diff: https://reviews.apache.org/r/9236/diff/
>
>
> Testing
> -------
>
> Unit tested:
> list and delete egress firewall rules from UI
>
>
> Thanks,
>
> Jayapal Reddy
>
>