[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1146: DISPATCH-2055: Eliminated log_lock and used the log_source_lock instead

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1146:
URL: https://github.com/apache/qpid-dispatch/pull/1146#discussion_r622495968



##########
File path: src/log.c
##########
@@ -425,7 +434,6 @@ void qd_vlog_impl(qd_log_source_t *source, qd_log_level_t level, bool check_leve
     }
 
     // Bounded buffer of log entries, keep most recent.
-    sys_mutex_lock(log_lock);
     qd_log_entry_t *entry = new_qd_log_entry_t();
     DEQ_ITEM_INIT(entry);
     entry->module = source->module;

Review comment:
       I am proposing that we just move the lock back to where it originally was, like just before this line - qd_log_entry_t *entry = new_qd_log_entry_t();




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org