You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Juanda Zeng (JIRA)" <ji...@apache.org> on 2006/01/16 03:57:20 UTC

[jira] Created: (AXIS2-391) ArchiveReader does not close the services.xml file

ArchiveReader does not close the services.xml file
--------------------------------------------------

         Key: AXIS2-391
         URL: http://issues.apache.org/jira/browse/AXIS2-391
     Project: Apache Axis 2.0 (Axis2)
        Type: Bug
  Components: deployment  
    Versions: 0.94    
 Environment: Windows XP Pro, JBoss
    Reporter: Juanda Zeng
    Priority: Trivial


The processServiceGroup(...) method does not seem to close the "InputStream in" after using it. This causes the file handle for services.xml to remain unreleased.

SUGGESTED RESOLUTION:
----------------------------------------
In org.apache.axis2.deployment.repository.util.ArchiveReader, add a finally block to close the InputStream after line 250 of rev. 367538, eg.:
                } finally {
                	if (in != null) {
                		try {
                			in.close();
                		} catch (IOException e) {
                		}
                	}
                }

There is a need to initialize the InputStream to null at line 239 as well.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AXIS2-391) ArchiveReader does not close the services.xml file

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-391?page=all ]
     
Davanum Srinivas resolved AXIS2-391:
------------------------------------

    Resolution: Fixed

looks like this has been fixed in latest SVN:
http://svn.apache.org/viewcvs.cgi/webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/deployment/repository/util/ArchiveReader.java?rev=370041&r1=367538&r2=370041&diff_format=h

thanks,
dims

> ArchiveReader does not close the services.xml file
> --------------------------------------------------
>
>          Key: AXIS2-391
>          URL: http://issues.apache.org/jira/browse/AXIS2-391
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: deployment
>     Versions: 0.94
>  Environment: Windows XP Pro, JBoss
>     Reporter: Juanda Zeng
>     Priority: Trivial

>
> The processServiceGroup(...) method does not seem to close the "InputStream in" after using it. This causes the file handle for services.xml to remain unreleased.
> SUGGESTED RESOLUTION:
> ----------------------------------------
> In org.apache.axis2.deployment.repository.util.ArchiveReader, add a finally block to close the InputStream after line 250 of rev. 367538, eg.:
>                 } finally {
>                 	if (in != null) {
>                 		try {
>                 			in.close();
>                 		} catch (IOException e) {
>                 		}
>                 	}
>                 }
> There is a need to initialize the InputStream to null at line 239 as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira