You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/06/02 11:52:33 UTC

[GitHub] [spark] beliefer opened a new pull request, #41436: [SPARK-37676][SPARK-37691][SQL][FOLLOWUP] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

beliefer opened a new pull request, #41436:
URL: https://github.com/apache/spark/pull/41436

   ### What changes were proposed in this pull request?
   Last year, I committed `Percentile[Cont|Disc]` functions for Spark SQL.
   Recently, I found the sql method of `Percentile[Cont|Disc]` doesn't display column's sql suitably.
   This PR will fix the bug.
   
   
   ### Why are the changes needed?
   Fix the bug doesn't display column's sql for `Percentile[Cont|Disc]`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'Yes'.
   Users could see the correct sql information.
   
   
   ### How was this patch tested?
   Test cases updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1574698893

   I'm +1 for backporting this to 3.4 and 3.3 if you want.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #41436: [SPARK-37676][SPARK-37691][SQL][FOLLOWUP] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1574661838

   > @beliefer This is too much ago for the follow up. Could you open a separate JIRA for this, and point out the versions 3.3 as the affected version.
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1574692517

   @wangyum @MaxGekk Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1574693752

   @wangyum Do we need merge this to 3.3 and 3.4?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum closed pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]
URL: https://github.com/apache/spark/pull/41436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #41436: [SPARK-43956][SQL] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1574665770

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #41436: [SPARK-37676][SPARK-37691][SQL][FOLLOWUP] Fix the bug doesn't display column's sql for Percentile[Cont|Disc]

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41436:
URL: https://github.com/apache/spark/pull/41436#issuecomment-1573898851

   > Last year, I committed Percentile[Cont|Disc] functions for Spark SQL.
   
   @beliefer This is too much ago for the follow up. Could you open a separate JIRA for this, and point out the versions 3.3 as the affected version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org