[GitHub] [pinot] npawar commented on a diff in pull request #10855: jsonPathString should return null instead of string literal "null"

["npawar (via GitHub)" <gi...@apache.org>]

npawar commented on code in PR #10855:
URL: https://github.com/apache/pinot/pull/10855#discussion_r1219984101


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/JsonFunctions.java:
##########
@@ -135,7 +135,7 @@ public static String jsonPathString(Object object, String jsonPath)
     if (jsonValue instanceof String) {
       return (String) jsonValue;
     }
-    return JsonUtils.objectToString(jsonValue);

Review Comment:
   during the null work, we introduced the convention to annotate these functions Nullable, as well as the params (check out examples in ObjectFunctions). Perhaps good to add here too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org