[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them
URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394330227
 
 

 ##########
 File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java
 ##########
 @@ -103,17 +104,25 @@ private SchemaMetaData loadDefaultSchemaMetaData() throws SQLException {
         return actualDefaultDataSourceName.isPresent()
                 ? SchemaMetaDataLoader.load(dataSourceMap.get(actualDefaultDataSourceName.get()), maxConnectionsSizePerQuery) : new SchemaMetaData(Collections.emptyMap());
     }
-    
-    // TODO check all meta data in once
+
     private void checkUniformed(final String logicTableName, final Map<String, TableMetaData> actualTableMetaDataMap) {
         ShardingTableMetaDataDecorator decorator = new ShardingTableMetaDataDecorator();
         TableMetaData sample = decorator.decorate(actualTableMetaDataMap.values().iterator().next(), logicTableName, shardingRule);
+        List<TableMetaDataViolation> metaDataViolationList = new LinkedList<>();
         for (Entry<String, TableMetaData> entry : actualTableMetaDataMap.entrySet()) {
-            if (!sample.equals(decorator.decorate(entry.getValue(), logicTableName, shardingRule))) {
-                throw new ShardingSphereException(
-                        "Cannot get uniformed table structure for logic table `%s` and actual table `%s`. The different meta data of actual tables are as follows:\n%s\n%s.",
-                        logicTableName, entry.getKey(), sample, entry.getValue());
+            TableMetaData entryValue = entry.getValue();
+            if (!sample.equals(decorator.decorate(entryValue, logicTableName, shardingRule))) {
+                metaDataViolationList.add(new TableMetaDataViolation(entry.getKey(), entryValue));
+            }
+        }
+        if (!metaDataViolationList.isEmpty()) {
+            StringBuilder exceptionMessageBuilder = new StringBuilder("Cannot get uniformed table structure for logic table `%s`"
+                    + ",it has different meta data of actual tables are as follows:");
 
 Review comment:
   It is better to add a space after symbol, such as `,` and `:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services