You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by Santiago Gala <sg...@apache.org> on 2005/08/18 13:19:30 UTC

Re: svn commit: r233305 - /portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java

El jue, 18-08-2005 a las 10:31 +0000, ate@apache.org escribió:
> Author: ate
> Date: Thu Aug 18 03:31:44 2005
> New Revision: 233305
> 
> URL: http://svn.apache.org/viewcvs?rev=233305&view=rev 
>  Log: Fix for
>  http://issues.apache.org/jira/browse/JS2-320. Commons Configuration
>  property value variable interpolation *only* is done when retrieving a
>  property value as String.
> 

Shouldn't that be considered a bug in commons-configuration? 

Great that it works now.

> Modified:
>     portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java
> 
> Modified: portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java
> URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java?rev=233305&r1=233304&r2=233305&view=diff
> ==============================================================================
> --- portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java (original)
> +++ portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java Thu Aug 18 03:31:44 2005
> @@ -78,7 +78,7 @@
>          String prop = System.getProperty(key);
>          if (prop == null)
>          {
> -            return (String) USER_PROPERTIES.getProperty(key);
> +            return USER_PROPERTIES.getString(key);
>          }
>          else
>          {
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> 
-- 
VP and Chair, Apache Portals (http://portals.apache.org)
Apache Software Foundation

Re: svn commit: r233305 - /portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java

Posted by Ate Douma <at...@douma.nu>.
Santiago Gala wrote:
> El jue, 18-08-2005 a las 10:31 +0000, ate@apache.org escribió:
> 
>>Author: ate
>>Date: Thu Aug 18 03:31:44 2005
>>New Revision: 233305
>>
>>URL: http://svn.apache.org/viewcvs?rev=233305&view=rev 
>> Log: Fix for
>> http://issues.apache.org/jira/browse/JS2-320. Commons Configuration
>> property value variable interpolation *only* is done when retrieving a
>> property value as String.
>>
> 
> 
> Shouldn't that be considered a bug in commons-configuration? 
No, I don't think so.
Property value variable interpolation only makes sense for string values.
Not documenting this explicitly though could be considered a (minor) "bug".

> 
> Great that it works now.
> 
> 
>>Modified:
>>    portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java
>>
>>Modified: portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java
>>URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java?rev=233305&r1=233304&r2=233305&view=diff
>>==============================================================================
>>--- portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java (original)
>>+++ portals/jetspeed-2/trunk/components/cm/src/java/org/apache/jetspeed/testhelpers/AbstractTestHelper.java Thu Aug 18 03:31:44 2005
>>@@ -78,7 +78,7 @@
>>         String prop = System.getProperty(key);
>>         if (prop == null)
>>         {
>>-            return (String) USER_PROPERTIES.getProperty(key);
>>+            return USER_PROPERTIES.getString(key);
>>         }
>>         else
>>         {
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
>>For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org