You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "lsq27 (via GitHub)" <gi...@apache.org> on 2023/07/30 15:46:28 UTC
[GitHub] [skywalking-booster-ui] lsq27 opened a new pull request, #307: fix: remove node-sass
lsq27 opened a new pull request, #307:
URL: https://github.com/apache/skywalking-booster-ui/pull/307
Since [LibSass and Node Sass are deprecated](https://sass-lang.com/blog/libsass-is-deprecated), we'd better [migrate to Sass](https://sass-lang.com/blog/libsass-is-deprecated/#how-do-i-migrate). Sass is already in package.json, just execute `npm uninstall -D node-sass`.
Scss file work fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 merged pull request #307: fix: remove node-sass
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 merged PR #307:
URL: https://github.com/apache/skywalking-booster-ui/pull/307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #307: fix: remove node-sass
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #307:
URL: https://github.com/apache/skywalking-booster-ui/pull/307#issuecomment-1657309509
>
It's a dev dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #307: fix: remove node-sass
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #307:
URL: https://github.com/apache/skywalking-booster-ui/pull/307#issuecomment-1657306922
@Fine0830 Is this a dev dependency or runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] lsq27 commented on pull request #307: fix: remove node-sass
Posted by "lsq27 (via GitHub)" <gi...@apache.org>.
lsq27 commented on PR #307:
URL: https://github.com/apache/skywalking-booster-ui/pull/307#issuecomment-1657216533
`node-sass` requires `node-gyp` which is really a troublesome thing for Windows users especially for thouse with network problems. The PR can completely solve https://github.com/apache/skywalking/issues/4463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org