[GitHub] [superset] diegomedina248 commented on a diff in pull request #22027: feat: Add 3 new extension points for inserting custom icons

[GitBox <gi...@apache.org>]

diegomedina248 commented on code in PR #22027:
URL: https://github.com/apache/superset/pull/22027#discussion_r1013335865


##########
superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.tsx:
##########
@@ -204,7 +223,14 @@ export default function HeaderReportDropDown({
     ) : (
       <Menu selectable={false} css={onMenuHover}>
         <Menu.Item onClick={handleShowMenu}>
-          {t('Set up an email report')}
+          {DropdownItemExtension ? (
+            <StyledDropdownItemWithIcon>
+              <div>{t('Set up an email report')}</div>
+              <DropdownItemExtension />

Review Comment:
   Do we want to be this specific, or could we use an extension for the whole item, passing down the text instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org