You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/11 09:51:27 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5389:
[AIRFLOW-4750] Log identified zombie task instances
ashb commented on a change in pull request #5389: [AIRFLOW-4750] Log identified zombie task instances
URL: https://github.com/apache/airflow/pull/5389#discussion_r292371086
##########
File path: airflow/utils/dag_processing.py
##########
@@ -1268,6 +1268,9 @@ def _find_zombies(self, session):
)
self._last_zombie_query_time = timezone.utcnow()
for ti in tis:
+ sti = SimpleTaskInstance(ti)
+ self.log.info("=> Failing job with dag_id %s, task_id %s, and execution date %s",
+ sti.dag_id, sti.task_id, sti.execution_date)
zombies.append(SimpleTaskInstance(ti))
Review comment:
```suggestion
zombies.append(sti)
```
No need to create the object twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services