[GitHub] [arrow] alamb commented on a change in pull request #8903: ARROW-9771: [Rust] [DataFusion] treat predicates separated by AND separately in predicate pushdown

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #8903:
URL: https://github.com/apache/arrow/pull/8903#discussion_r541906226



##########
File path: rust/datafusion/src/optimizer/filter_push_down.rs
##########
@@ -215,13 +215,38 @@ fn issue_filters(
     push_down(&state, &plan)
 }
 
+/// converts "A AND B AND C" => [A, B, C]
+fn split_members(predicate: &Expr) -> Vec<&Expr> {

Review comment:
       Eventually (as part of some other PR) this code might more naturally belong in the utils.rs module -- splitting expressions into an AND list is a common thing to want to do, I think. It would make the code easier to find if people need it for other optimizations. I feel like I have seen this code before in DataFusion but I can't find it now...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org