[jira] [Closed] (ASTERIXDB-1929) Factor out isAntimatter from TupleWriter and TupleWriterFactory

["Yingyi Bu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ASTERIXDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yingyi Bu closed ASTERIXDB-1929.
--------------------------------
    Resolution: Fixed

Fixed in the latest master.

> Factor out isAntimatter from TupleWriter and TupleWriterFactory
> ---------------------------------------------------------------
>
>                 Key: ASTERIXDB-1929
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1929
>             Project: Apache AsterixDB
>          Issue Type: Improvement
>          Components: Storage
>            Reporter: Yingyi Bu
>            Assignee: Chen Luo
>
> isAntimatter is a property of the tuple that we're writing, but not a property of the Writer.  Hence, we probably should remove setAntimatter(...) from the TupleWriter.
> Currently, for each tuple write operation, we need to call setAntimatter() in both TupleWriterFactory and TupleWriter.  This is painful and potentially buggy -- a XxxFactory typically is one per NC.
> Instead, we can add a parameter to write tuple method:
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) 
> ->
> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)