You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chenglei (Jira)" <ji...@apache.org> on 2023/04/06 13:53:00 UTC
[jira] [Comment Edited] (HBASE-27778) Incorrect ReplicationSourceWALReader. totalBufferUsed may cause replication hang up
[ https://issues.apache.org/jira/browse/HBASE-27778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709387#comment-17709387 ]
chenglei edited comment on HBASE-27778 at 4/6/23 1:52 PM:
----------------------------------------------------------
Pushed to 2.6+, thanks [~zhangduo] and [~Xiaolin Ha] for review.
was (Author: comnetwork):
Pushed to 2.6+, thanks [~zhangduo] and [~Xiaolin Ha]
> Incorrect ReplicationSourceWALReader. totalBufferUsed may cause replication hang up
> ------------------------------------------------------------------------------------
>
> Key: HBASE-27778
> URL: https://issues.apache.org/jira/browse/HBASE-27778
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 2.6.0, 3.0.0-alpha-3
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
>
> When we read a new WAL Entry in {{ReplicationSourceWALReader.readWALEntries}}, we add {{ReplicationSourceWALReader.totalBufferUsed}} by the size of new entry in {{ReplicationSourceWALReader.addEntryToBatch}}, but the whole {{WALEntryBatch}} may not be put to the {{ReplicationSourceWALReader.entryBatchQueue}} because of exception(eg. exception thrown by {{WALEntryFilter.filter}} for following WAL Entry), and the {{ReplicationSourceWALReader.totalBufferUsed}} is not decreased in this case. Because the {{ReplicationSourceWALReader.totalBufferUsed}} is actually scoped to {{ReplicationSourceManager}}, after a long run, replication to all peers may hang up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)